Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-03 Thread Yao, Lei A
; Zhang, Helin ; > ophi...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > memcpy > > 02/11/2017 11:22, Wang, Zhihong: > > > I don't know what is creating this drop exactly. > > > When doing different tests on different envir

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-02 Thread Thomas Monjalon
02/11/2017 11:58, Li, Xiaoyun: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 02/11/2017 11:22, Wang, Zhihong: > > > > I don't know what is creating this drop exactly. > > > > When doing different tests on different environments, we do not see > > > > this drop. > > > > If nobody else can

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-02 Thread Li, Xiaoyun
@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > memcpy > > 02/11/2017 11:22, Wang, Zhihong: > > > I don't know what is creating this drop exactly. > > > When doing different tests on different environments, we do not see > &

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-02 Thread Thomas Monjalon
02/11/2017 11:22, Wang, Zhihong: > > I don't know what is creating this drop exactly. > > When doing different tests on different environments, we do not see this > > drop. > > If nobody else can see such issue, I guess we can ignore it. > > Hi Thomas, Xiaoyun, > > With this patch (commit 84cc318

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-02 Thread Wang, Zhihong
> I don't know what is creating this drop exactly. > When doing different tests on different environments, we do not see this > drop. > If nobody else can see such issue, I guess we can ignore it. Hi Thomas, Xiaoyun, With this patch (commit 84cc318424d49372dd2a5fbf3cf84426bf95acce) I see more tha

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-29 Thread Thomas Monjalon
25/10/2017 09:25, Thomas Monjalon: > 25/10/2017 08:55, Li, Xiaoyun: > > From: Li, Xiaoyun > > > From: Richardson, Bruce > > > > On Thu, Oct 19, 2017 at 11:00:33AM +0200, Thomas Monjalon wrote: > > > > > 19/10/2017 10:50, Li, Xiaoyun: > > > > > > From: Thomas Monjalon > > > > > > > 19/10/2017 09:51,

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-25 Thread Li, Xiaoyun
t: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > memcpy > > 25/10/2017 10:54, Li, Xiaoyun: > > > > > > > I think we should focus on micro-benchmark and find a > > > > > > > reasonnable threshold for a reasonnable drop tradeof

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-25 Thread Ananyev, Konstantin
2017 7:55 AM > > > To: Li, Xiaoyun ; Richardson, Bruce > > > ; Thomas Monjalon > > > Cc: Ananyev, Konstantin ; dev@dpdk.org; > > > Lu, Wenzhuo ; Zhang, Helin > > > ; ophi...@mellanox.com > > > Subject: RE: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-t

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-25 Thread Thomas Monjalon
25/10/2017 10:54, Li, Xiaoyun: > > > > > > I think we should focus on micro-benchmark and find a > > > > > > reasonnable threshold for a reasonnable drop tradeoff. > > > > > > > > > > > Sadly, it may not be that simple. What shows best performance for > > > > > micro- benchmarks may not show the sa

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-25 Thread Li, Xiaoyun
g; > > Lu, Wenzhuo ; Zhang, Helin > > ; ophi...@mellanox.com > > Subject: RE: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > > memcpy > > > > Hi > > > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.or

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-25 Thread Ananyev, Konstantin
gt; > > > Cc: Ananyev, Konstantin ; dev@dpdk.org; > > Lu, Wenzhuo ; Zhang, Helin > > ; ophi...@mellanox.com > > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > > memcpy > > > > > > > > > -Original Message---

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-25 Thread Thomas Monjalon
25/10/2017 08:55, Li, Xiaoyun: > From: Li, Xiaoyun > > From: Richardson, Bruce > > > On Thu, Oct 19, 2017 at 11:00:33AM +0200, Thomas Monjalon wrote: > > > > 19/10/2017 10:50, Li, Xiaoyun: > > > > > From: Thomas Monjalon > > > > > > 19/10/2017 09:51, Li, Xiaoyun: > > > > > > > From: Thomas Monjalon

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-24 Thread Li, Xiaoyun
llanox.com > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > memcpy > > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Thursday, October 19, 2017 17:30 > > To: Thomas Monjalon > > Cc: Li, Xiaoyun ; A

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Li, Xiaoyun
net] > > > > Sent: Thursday, October 19, 2017 16:34 > > > > To: Li, Xiaoyun > > > > Cc: Ananyev, Konstantin ; > > > > Richardson, Bruce ; dev@dpdk.org; Lu, > > > > Wenzhuo ; Zhang, Helin > > > > ; ophi...@mellanox.com > > > &

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Bruce Richardson
o: Li, Xiaoyun > > > Cc: Ananyev, Konstantin ; Richardson, > > > Bruce ; dev@dpdk.org; Lu, Wenzhuo > > > ; Zhang, Helin ; > > > ophi...@mellanox.com > > > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > > > memcpy &g

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Thomas Monjalon
, Wenzhuo > > ; Zhang, Helin ; > > ophi...@mellanox.com > > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > > memcpy > > > > 19/10/2017 09:51, Li, Xiaoyun: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > >

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Ananyev, Konstantin
gt; > Bruce ; dev@dpdk.org; Lu, Wenzhuo > > ; Zhang, Helin ; > > ophi...@mellanox.com > > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > > memcpy > > > > 19/10/2017 09:51, Li, Xiaoyun: > > > From: Thomas Monjalon [mailto:tho...@monjalon.ne

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Li, Xiaoyun
t: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > memcpy > > 19/10/2017 09:51, Li, Xiaoyun: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 19/10/2017 04:45, Li, Xiaoyun: > > > > Hi > > > > > > > > > >

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Thomas Monjalon
19/10/2017 09:51, Li, Xiaoyun: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 19/10/2017 04:45, Li, Xiaoyun: > > > Hi > > > > > > > > > > > > The significant change of this patch is to call a function > > > > > > pointer for packet size > 128 (RTE_X86_MEMCPY_THRESH). > > > > > The perf dr

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-19 Thread Li, Xiaoyun
t: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > memcpy > > 19/10/2017 04:45, Li, Xiaoyun: > > Hi > > > > > > > > > > The significant change of this patch is to call a function > > > > > pointer for packet size > 1

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-18 Thread Thomas Monjalon
19/10/2017 04:45, Li, Xiaoyun: > Hi > > > > > > > > The significant change of this patch is to call a function pointer > > > > for packet size > 128 (RTE_X86_MEMCPY_THRESH). > > > The perf drop is due to function call replacing inline. > > > > > > > Please could you provide some benchmark numbers?

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-18 Thread Li, Xiaoyun
Hi > > > > > > The significant change of this patch is to call a function pointer > > > for packet size > 128 (RTE_X86_MEMCPY_THRESH). > > The perf drop is due to function call replacing inline. > > > > > Please could you provide some benchmark numbers? > > I ran memcpy_perf_test which would show t

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-17 Thread Li, Xiaoyun
llanox.com > Subject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > memcpy > > Hi > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, October 18, 2017 05:24 > > To: Li, Xiaoyun ; Ananye

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-17 Thread Li, Xiaoyun
ject: Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over > memcpy > > Hi, > > 13/10/2017 11:01, Xiaoyun Li: > > This patch dynamically selects functions of memcpy at run-time based > > on CPU flags that current machine supports. This patch uses function &g

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-17 Thread Thomas Monjalon
Hi, 13/10/2017 11:01, Xiaoyun Li: > This patch dynamically selects functions of memcpy at run-time based > on CPU flags that current machine supports. This patch uses function > pointers which are bind to the relative functions at constrctor time. > In addition, AVX512 instructions set would be co

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-13 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 13, 2017 10:29 AM > To: Li, Xiaoyun ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Richardson, Bruce ; Lu, Wenzhuo > ; Zhang, Helin > > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-13 Thread Thomas Monjalon
13/10/2017 11:01, Xiaoyun Li: > lib/librte_eal/common/arch/x86/rte_memcpy.c| 59 ++ > lib/librte_eal/common/arch/x86/rte_memcpy_avx2.c | 44 + > .../common/arch/x86/rte_memcpy_avx512f.c | 44 + > lib/librte_eal/common/arch/x86/rte_memcpy_sse.c| 40 + > .../common/includ

[dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-10-13 Thread Xiaoyun Li
This patch dynamically selects functions of memcpy at run-time based on CPU flags that current machine supports. This patch uses function pointers which are bind to the relative functions at constrctor time. In addition, AVX512 instructions set would be compiled only if users config it enabled and