Re: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation

2020-07-12 Thread Ivan Dyukov
12.07.2020 10:35, Thomas Monjalon пишет: > 11/07/2020 20:58, Ivan Dyukov: >> 11.07.2020 14:27, Thomas Monjalon пишет: >>> 11/07/2020 12:43, Ivan Dyukov: +__rte_experimental +int rte_eth_link_printf(const char *const fmt, + const struct rte_eth_link *eth_link); >

Re: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation

2020-07-12 Thread Stephen Hemminger
On Sun, 12 Jul 2020 09:35:23 +0200 Thomas Monjalon wrote: > 11/07/2020 20:58, Ivan Dyukov: > > 11.07.2020 14:27, Thomas Monjalon пишет: > > > 11/07/2020 12:43, Ivan Dyukov: > > >> +__rte_experimental > > >> +int rte_eth_link_printf(const char *const fmt, > > >> + const s

Re: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation

2020-07-12 Thread Thomas Monjalon
11/07/2020 20:58, Ivan Dyukov: > 11.07.2020 14:27, Thomas Monjalon пишет: > > 11/07/2020 12:43, Ivan Dyukov: > >> +__rte_experimental > >> +int rte_eth_link_printf(const char *const fmt, > >> + const struct rte_eth_link *eth_link); > >> > > Maybe I missed your reply, > > I sti

Re: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation

2020-07-11 Thread Ivan Dyukov
11.07.2020 14:27, Thomas Monjalon пишет: > 11/07/2020 12:43, Ivan Dyukov: >> +__rte_experimental >> +int rte_eth_link_printf(const char *const fmt, >> + const struct rte_eth_link *eth_link); >> > Maybe I missed your reply, > I still don't understand the need for this function.

Re: [dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation

2020-07-11 Thread Thomas Monjalon
11/07/2020 12:43, Ivan Dyukov: > +__rte_experimental > +int rte_eth_link_printf(const char *const fmt, > + const struct rte_eth_link *eth_link); > Maybe I missed your reply, I still don't understand the need for this function.

[dpdk-dev] [PATCH v8 02/24] ethdev: add a link status text representation

2020-07-11 Thread Ivan Dyukov
link status structure keeps complicated values which are hard to represent to end user. e.g. link_speed has INT_MAX value which means that speed is unknown. To simplify processing of the values in application, new dpdk function is introduced. This commit adds function which treat link status struc