Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-09 Thread Ferruh Yigit
On 5/9/2018 3:11 PM, Ferruh Yigit wrote: > On 5/8/2018 6:51 PM, Andrew Rybchenko wrote: >> On 05/08/2018 01:10 PM, Wei Dai wrote: >>> This patch check if a input requested offloading is valid or not. >>> Any reuqested offloading must be supported in the device capabilities. >>> Any offloading is di

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-09 Thread Dai, Wei
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, May 8, 2018 8:13 PM > To: Dai, Wei ; tho...@monjalon.net; Doherty, Declan > ; linvi...@tuxdriver.com; m...@semihalf.com; > m...@semihalf.com; gtza...@amazon.com; evge...@amazon.com; > ravi1.ku...@amd.com; shepard.sie...@atomicrules

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-09 Thread Ferruh Yigit
On 5/8/2018 6:51 PM, Andrew Rybchenko wrote: > On 05/08/2018 01:10 PM, Wei Dai wrote: >> This patch check if a input requested offloading is valid or not. >> Any reuqested offloading must be supported in the device capabilities. >> Any offloading is disabled by default if it is not set in the param

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-09 Thread Dai, Wei
Hi, Andrew See my in-line comments as below. From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Tuesday, May 8, 2018 7:37 PM To: Dai, Wei ; Yigit, Ferruh ; tho...@monjalon.net; Doherty, Declan ; linvi...@tuxdriver.com; m...@semihalf.com; m...@semihalf.com; gtza...@amazon.com; evge

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Dai, Wei
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Wednesday, May 9, 2018 1:52 AM > To: Dai, Wei ; Yigit, Ferruh ; > tho...@monjalon.net; shah...@mellanox.com; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Andrew Rybchenko
On 05/08/2018 01:10 PM, Wei Dai wrote: This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_confi

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Ferruh Yigit
On 5/8/2018 11:05 AM, Wei Dai wrote: > This patch check if a input requested offloading is valid or not. > Any reuqested offloading must be supported in the device capabilities. > Any offloading is disabled by default if it is not set in the parameter > dev_conf->[rt]xmode.offloads to rte_eth_dev_c

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Andrew Rybchenko
On 05/08/2018 01:05 PM, Wei Dai wrote: This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_confi

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Andrew Rybchenko
On 05/08/2018 02:02 PM, Ferruh Yigit wrote: On 5/8/2018 11:41 AM, Andrew Rybchenko wrote: On 05/08/2018 01:05 PM, Wei Dai wrote: [...] In the beginning of [rt]x_queue_setup( ) of underlying PMD, add offloads = [rt]xconf->offloads | dev->data->dev_conf.[rt]xmode.offloads; to keep same as offlo

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Ferruh Yigit
On 5/8/2018 11:41 AM, Andrew Rybchenko wrote: > On 05/08/2018 01:05 PM, Wei Dai wrote: > > [...] > >> In the beginning of [rt]x_queue_setup( ) of underlying PMD, >> add offloads = [rt]xconf->offloads | >> dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API >> defined in 17.11 to a

Re: [dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Andrew Rybchenko
On 05/08/2018 01:05 PM, Wei Dai wrote: [...] In the beginning of [rt]x_queue_setup( ) of underlying PMD, add offloads = [rt]xconf->offloads | dev->data->dev_conf.[rt]xmode.offloads; to keep same as offload API defined in 17.11 to avoid upper application broken due to offload API change. PMD can

[dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and [rt]x_conf->offloads to rte_e

[dpdk-dev] [PATCH v8] ethdev: check Rx/Tx offloads

2018-05-08 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and [rt]x_conf->offloads to rte_e