Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser

2018-04-25 Thread Remy Horton
On 25/04/2018 11:06, Thomas Monjalon wrote: 25/04/2018 11:40, Remy Horton: On 24/04/2018 20:53, Thomas Monjalon wrote: [..] OK Please can you add it as a comment in the parsing code? We will need one or two examples in the commit message too. Docs are being updated, so it should be in the

Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser

2018-04-25 Thread Thomas Monjalon
25/04/2018 11:40, Remy Horton: > > On 24/04/2018 20:53, Thomas Monjalon wrote: > [..] > > But I would like to review the devargs you are standardizing. > > Unfortunately, I cannot find a documentation about it. > > How users are supposed to use it? > > Can you, at least, describe the syntax in the

Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser

2018-04-25 Thread Remy Horton
On 24/04/2018 20:53, Thomas Monjalon wrote: [..] But I would like to review the devargs you are standardizing. Unfortunately, I cannot find a documentation about it. How users are supposed to use it? Can you, at least, describe the syntax in the commit log, please? The patch follows this pseud

Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser

2018-04-24 Thread Thomas Monjalon
16/04/2018 15:06, Declan Doherty: > From: Remy Horton > > Introduces a new structure, rte_eth_devargs, to support generic > ethdev arguments common across NET PMDs, with a new API > rte_eth_devargs_parse API to support PMD parsing these arguments. Most of the parsing functions should be removed

Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser

2018-04-20 Thread Ananyev, Konstantin
> Introduces a new structure, rte_eth_devargs, to support generic > ethdev arguments common across NET PMDs, with a new API > rte_eth_devargs_parse API to support PMD parsing these arguments. > > Signed-off-by: Remy Horton > Signed-off-by: Declan Doherty > --- > lib/Makefile

[dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser

2018-04-16 Thread Declan Doherty
From: Remy Horton Introduces a new structure, rte_eth_devargs, to support generic ethdev arguments common across NET PMDs, with a new API rte_eth_devargs_parse API to support PMD parsing these arguments. Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- lib/Makefile