Re: [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-06 Thread Yuanhan Liu
On Fri, May 05, 2017 at 04:21:53PM +0200, Thomas Monjalon wrote: > 05/05/2017 02:40, Wei Dai: > > Some customers find adding MAC addr to VF sometimes can fail, > > but it is still stored in dev->data->mac_addrs[ ]. So this > > can lead to some errors that assumes the non-zero entry in > > dev->data

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-05 Thread Thomas Monjalon
05/05/2017 02:40, Wei Dai: > Some customers find adding MAC addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > Following acknowledgements are from specific NIC

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-05 Thread Thomas Monjalon
05/05/2017 02:40, Wei Dai: > Some customers find adding MAC addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > Following acknowledgements are from specific NIC

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-05 Thread Thomas Monjalon
05/05/2017 03:46, Yang, Qiming: > Hi, Dai wei > > > static void > > diff --git a/drivers/net/e1000/igb_ethdev.c > > b/drivers/net/e1000/igb_ethdev.c index b6b81cb..e8c6282 100644 > > --- a/drivers/net/e1000/igb_ethdev.c > > +++ b/drivers/net/e1000/igb_ethdev.c > > @@ -171,9 +171,9 @@ static int e

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-04 Thread Yang, Qiming
Hi, Dai wei > static void > diff --git a/drivers/net/e1000/igb_ethdev.c > b/drivers/net/e1000/igb_ethdev.c index b6b81cb..e8c6282 100644 > --- a/drivers/net/e1000/igb_ethdev.c > +++ b/drivers/net/e1000/igb_ethdev.c > @@ -171,9 +171,9 @@ static int eth_igb_led_off(struct rte_eth_dev *dev); > > s

[dpdk-dev] [PATCH v7 1/3] ethdev: fix adding invalid MAC addr

2017-05-04 Thread Wei Dai
Some customers find adding MAC addr to VF sometimes can fail, but it is still stored in dev->data->mac_addrs[ ]. So this can lead to some errors that assumes the non-zero entry in dev->data->mac_addrs[ ] is valid. Following acknowledgements are from specific NIC PMD maintainer for their managing pa