Re: [dpdk-dev] [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread

2018-04-25 Thread Arnon Warshavsky
> Just a general comment - i'm not too familiar with this code, but it looks > like all of these failures will only happen on thread init. Can we make > sure it starts? > > You can use similar approach to Olivier's (recently merged) thread > affinity patches, with pthread barriers etc. to ensure th

Re: [dpdk-dev] [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread

2018-04-25 Thread Burakov, Anatoly
On 24-Apr-18 11:16 PM, Arnon Warshavsky wrote: replace panic calls with log and return value. Thread function removes the noreturn attribute. Signed-off-by: Arnon Warshavsky --- Just a general comment - i'm not too familiar with this code, but it looks like all of these failures will only ha

[dpdk-dev] [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread

2018-04-24 Thread Arnon Warshavsky
replace panic calls with log and return value. Thread function removes the noreturn attribute. Signed-off-by: Arnon Warshavsky --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/lib/librte_eal/linuxapp/e