> Subject: Re: [PATCH v7 02/25] ethdev: add a link status text representation
>
> 10.07.2020 16:06, Yigit, Ferruh пишет:
> > On 7/10/2020 8:02 AM, Ivan Dyukov wrote:
> >> This commit add function which treat link status structure and format
> >> it to text representation.
> >>
> >> Signed-off-by:
10.07.2020 18:22, Stephen Hemminger пишет:
> On Fri, 10 Jul 2020 13:06:02 +
> "Yigit, Ferruh" wrote:
>
>>> + /* ignore unknown specifier */
>>> + default:
>>> + *str_cur = '%';
>>> + offset++;
>>> +
10.07.2020 16:06, Yigit, Ferruh пишет:
> On 7/10/2020 8:02 AM, Ivan Dyukov wrote:
>> This commit add function which treat link status structure
>> and format it to text representation.
>>
>> Signed-off-by: Ivan Dyukov
> <...>
>
>> +static int
>> +rte_eth_link_strf_parser(char *str, size_t len, con
> On Fri, 10 Jul 2020 13:06:02 +
> "Yigit, Ferruh" wrote:
>
> > > + /* ignore unknown specifier */
> > > + default:
> > > + *str_cur = '%';
> > > + offset++;
> > > + fmt_cur--;
> > > +
On Fri, 10 Jul 2020 13:06:02 +
"Yigit, Ferruh" wrote:
> > + /* ignore unknown specifier */
> > + default:
> > + *str_cur = '%';
> > + offset++;
> > + fmt_cur--;
> > +
10/07/2020 09:02, Ivan Dyukov:
> This commit add function which treat link status structure
> and format it to text representation.
It is missing an explanation about why it is required.
Which problem is it solving?
> Signed-off-by: Ivan Dyukov
I'm surprised there is not so much review on this
On 7/10/2020 8:02 AM, Ivan Dyukov wrote:
> This commit add function which treat link status structure
> and format it to text representation.
>
> Signed-off-by: Ivan Dyukov
<...>
> +static int
> +rte_eth_link_strf_parser(char *str, size_t len, const char *const fmt,
> +c
This commit add function which treat link status structure
and format it to text representation.
Signed-off-by: Ivan Dyukov
---
MAINTAINERS | 1 +
app/test/Makefile| 3 +
app/test/meson.build | 2 +
app/test/test_ethd
8 matches
Mail list logo
