On Mon, Oct 10, 2016 at 10:49:22AM +, Kavanagh, Mark B wrote:
> >
> >On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote:
> >> /*
> >> * dev_ops for virtio, bare necessities for basic operation
> >> */
> >> @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
> >>
>-Original Message-
>From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
>Sent: Tuesday, October 11, 2016 5:01 AM
>To: Kavanagh, Mark B
>Cc: Dey ; stephen at networkplumber.org; dev at dpdk.org
>Subject: Re: [PATCH v7] net/virtio: add set_mtu in virtio
>
>On Mon, Oct 10, 2016 at 10:
>
>On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote:
>> /*
>> * dev_ops for virtio, bare necessities for basic operation
>> */
>> @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
>> .allmulticast_enable = virtio_dev_allmulticast_enable,
>> .allmultica
On Thu, Sep 29, 2016 at 04:31:30PM -0400, Dey wrote:
> /*
> * dev_ops for virtio, bare necessities for basic operation
> */
> @@ -677,7 +685,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = {
> .allmulticast_enable = virtio_dev_allmulticast_enable,
> .allmulticast_disa
I think current patch is fine. If someone has later problem with it on some
scenario we can fix the bug then.
Please merge
Hi Stephen,
As I am new to this patch submission, I did not get what you
exactly meant my ?Please merge?, do you mean that you Ack the patch and it can
be upstreamed or you want me submit a new version or something. Sorry for my
ignorance.
Thanks
--
Souvik
From: Stephen Hemminger
networkplumber.org
>Cc: dev at dpdk.org
>Subject: Re: [dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio
>
>Yes Mark, I have modified the patch with the below comments.
>
>drivers/net/virtio/virtio_ethdev.c | 17 +
> 1 file changed, 17 insertions(+)
>
: Kavanagh, Mark B ; yuanhan.liu at
linux.intel.com; stephen at networkplumber.org
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7] net/virtio: add set_mtu in virtio
Yes Mark, I have modified the patch with the below comments.
drivers/net/virtio/virtio_ethdev.c | 17 +
1 file
Yes Mark, I have modified the patch with the below comments.
drivers/net/virtio/virtio_ethdev.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virtio_ethdev.c
index 423c597..1dbfea6 100644
--- a/drivers/net/virtio/vir
>Hi All,
> Is there any further comments or modifications required for this patch,
> or what next
>steps do you guys suggest here ?
Hi Souvik,
Some minor comments inline.
Thanks,
Mark
>
>--
>Regards,
>Souvik
>
>-Original Message-
>From: Dey, Souvik
>Sent: Saturday, October 1, 201
Hi All,
Is there any further comments or modifications required for this patch,
or what next steps do you guys suggest here ?
--
Regards,
Souvik
-Original Message-
From: Dey, Souvik
Sent: Saturday, October 1, 2016 10:09 AM
To: mark.b.kavanagh at intel.com; yuanhan.liu at linux.i
Hi Liu/Stephen/Mark,
I have submitted Version 7 of this patch. Do let me know if this looks
proper.
--
Regards,
Souvik
-Original Message-
From: Dey, Souvik
Sent: Thursday, September 29, 2016 4:32 PM
To: mark.b.kavanagh at intel.com; yuanhan.liu at linux.intel.com; stephen at
Virtio interfaces do not currently allow the user to specify a particular
Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces
is typically set to the Ethernet default value of 1500.
This is problematic in the case of cloud deployments, in which a specific
(and potentially
13 matches
Mail list logo
