Re: [dpdk-dev] [PATCH v7] ethdev: add sanity checks in control APIs

2021-04-17 Thread Min Hu (Connor)
在 2021/4/16 20:02, Thomas Monjalon 写道: 16/04/2021 13:00, Min Hu (Connor): + if (iter == NULL) { + RTE_ETHDEV_LOG(ERR, "Cannot init iterator for NULL iterator\n"); Don't you think it would be better as "Cannot init NULL iterator"? rte_eth_iterator_cleanup(struct rte_d

Re: [dpdk-dev] [PATCH v7] ethdev: add sanity checks in control APIs

2021-04-16 Thread Thomas Monjalon
16/04/2021 13:00, Min Hu (Connor): > + if (iter == NULL) { > + RTE_ETHDEV_LOG(ERR, "Cannot init iterator for NULL iterator\n"); Don't you think it would be better as "Cannot init NULL iterator"? > rte_eth_iterator_cleanup(struct rte_dev_iterator *iter) > { > + if (iter == NU

Re: [dpdk-dev] [PATCH v7] ethdev: add sanity checks in control APIs

2021-04-16 Thread Ferruh Yigit
On 4/16/2021 12:00 PM, Min Hu (Connor) wrote: This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for inval

[dpdk-dev] [PATCH v7] ethdev: add sanity checks in control APIs

2021-04-16 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f