[dpdk-dev] [PATCH v7] eal: map uio resources after hugepages.

2014-11-07 Thread XU Liang
I got it. Just some guys don't like global variable. I'm not sure what is DPDK code style.--From:Burakov, Anatoly Time:2014 Nov 7 (Fri) 23 : 15To:?? , dev at dpdk.org Cc:thomas.monjalon at 6wind.com , De Lara Guarch, Pablo Subjec

[dpdk-dev] [PATCH v7] eal: map uio resources after hugepages.

2014-11-07 Thread lxu
A multiple process DPDK application must mmap hugepages and pci resources into same virtual addresses. By default the virtual addresses chosen by the primary process automatically when calling the mmap. But sometime the chosen virtual addresses isn't usable at secondary process. Such as the seco

[dpdk-dev] [PATCH v7] eal: map uio resources after hugepages.

2014-11-07 Thread Thomas Monjalon
Hi Liang, I see you are learning how to send a patch. It's a good thing. I don't know if the idea of your patch will be accepted but here are more tips about formatting: - You should use checkpatch.pl from kernel.org and fix the most important issues - The commit log should be wrapped to avoid lon

[dpdk-dev] [PATCH v7] eal: map uio resources after hugepages.

2014-11-07 Thread Burakov, Anatoly
Um, not sure I agree with this implementation. I think a cleaner way would be to put the requested_addr in pci_uio_map_resource and pci_vfio_map_resource (or rather, put it in include/eal_pci_init.h, like extern void *requested_addr) but make actual use of it in pci_uio/vfio_map_resource only (a