Re: [dpdk-dev] [PATCH v6 7/8] devtools: remove check-includes script

2021-01-28 Thread Thomas Monjalon
28/01/2021 12:38, Bruce Richardson: > On Thu, Jan 28, 2021 at 12:10:41PM +0100, Thomas Monjalon wrote: > > 27/01/2021 18:33, Bruce Richardson: > > > +* The ``check-includes.sh`` script for checking DPDK header files has > > > been + removed, being replaced by the ``check_includes`` build option >

Re: [dpdk-dev] [PATCH v6 7/8] devtools: remove check-includes script

2021-01-28 Thread Bruce Richardson
On Thu, Jan 28, 2021 at 12:10:41PM +0100, Thomas Monjalon wrote: > 27/01/2021 18:33, Bruce Richardson: > > +* The ``check-includes.sh`` script for checking DPDK header files has > > been + removed, being replaced by the ``check_includes`` build option > > described above. > > How do they compare?

Re: [dpdk-dev] [PATCH v6 7/8] devtools: remove check-includes script

2021-01-28 Thread Thomas Monjalon
27/01/2021 18:33, Bruce Richardson: > +* The ``check-includes.sh`` script for checking DPDK header files has been > + removed, being replaced by the ``check_includes`` build option described > above. How do they compare? Is the new test checking C++ compliance? pedantic?

[dpdk-dev] [PATCH v6 7/8] devtools: remove check-includes script

2021-01-27 Thread Bruce Richardson
The check-includes script allowed checking header files in a given directory to ensure that each header compiled alone without requiring any other header inclusions. With header checking now being done by the chkincs app in the build system this script can be removed. Signed-off-by: Bruce Richard