Re: [dpdk-dev] [PATCH v6 6/6] ethdev: complete closing of port

2018-10-19 Thread Andrew Rybchenko
On 10/19/18 5:07 AM, Thomas Monjalon wrote: After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should che

[dpdk-dev] [PATCH v6 6/6] ethdev: complete closing of port

2018-10-18 Thread Thomas Monjalon
After closing a port, it cannot be restarted. So there is no reason to not free all associated resources. The last step was done with rte_eth_dev_detach() which is deprecated. Instead of blindly removing the associated rte_device, the driver should check if no more port (ethdev, cryptodev, etc) is