Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-31 Thread Shahaf Shuler
Thursday, March 29, 2018 5:53 PM, Doherty, Declan: > On 29/03/2018 7:13 AM, Shahaf Shuler wrote: > > Wednesday, March 28, 2018 4:54 PM, Declan Doherty: > >> Subject: [dpdk-dev][PATCH v6 4/8] ethdev: Add port representor device > >> flag > >> > >> Add n

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-29 Thread Doherty, Declan
On 29/03/2018 7:13 AM, Shahaf Shuler wrote: Wednesday, March 28, 2018 4:54 PM, Declan Doherty: Subject: [dpdk-dev][PATCH v6 4/8] ethdev: Add port representor device flag Add new device flag to specify that ethdev port is a port representor. Extend rte_eth_dev_info structure to expose device

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-29 Thread Thomas Monjalon
29/03/2018 08:13, Shahaf Shuler: > And device attributes like : RTE_ETH_DEV_BONDED_SLAVE and > RTE_ETH_DEV_REPRESENTOR. > I don't think they belong together under the genetic name of dev_flags. > > Moreover, I am not sure the fact device is bonded slave should be exposed to > the application. I

Re: [dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-28 Thread Shahaf Shuler
Wednesday, March 28, 2018 4:54 PM, Declan Doherty: > Subject: [dpdk-dev][PATCH v6 4/8] ethdev: Add port representor device flag > > Add new device flag to specify that ethdev port is a port representor. > Extend rte_eth_dev_info structure to expose device flags to user which > enab

[dpdk-dev] [PATCH v6 4/8] ethdev: Add port representor device flag

2018-03-28 Thread Declan Doherty
Add new device flag to specify that ethdev port is a port representor. Extend rte_eth_dev_info structure to expose device flags to user which enable applications to discover if a port is a representor port. Signed-off-by: Declan Doherty --- lib/librte_ether/rte_ethdev.c | 1 + lib/li