Re: [dpdk-dev] [PATCH v6 4/4] log: add option argument help

2021-04-06 Thread David Marchand
On Tue, Apr 6, 2021 at 6:04 PM Thomas Monjalon wrote: > > 06/04/2021 15:11, Thomas Monjalon: > > --- a/lib/librte_eal/version.map > > +++ b/lib/librte_eal/version.map > > # added in 21.05 > > + rte_log_list_types; > > The symbol should be added in the .def as well. > Yes, and I'm fed up

Re: [dpdk-dev] [PATCH v6 4/4] log: add option argument help

2021-04-06 Thread Thomas Monjalon
06/04/2021 15:11, Thomas Monjalon: > --- a/lib/librte_eal/version.map > +++ b/lib/librte_eal/version.map > # added in 21.05 > + rte_log_list_types; The symbol should be added in the .def as well.

Re: [dpdk-dev] [PATCH v6 4/4] log: add option argument help

2021-04-06 Thread Thomas Monjalon
06/04/2021 16:28, David Marchand: > On Tue, Apr 6, 2021 at 3:12 PM Thomas Monjalon wrote: > > +void > > +rte_log_list_types(FILE *out, const char *prefix) > > +{ > > + struct rte_log_dynamic_type *sorted_types; > > + const size_t type_size = sizeof(rte_logs.dynamic_types[0]); > > +

Re: [dpdk-dev] [PATCH v6 4/4] log: add option argument help

2021-04-06 Thread David Marchand
On Tue, Apr 6, 2021 at 3:12 PM Thomas Monjalon wrote: > @@ -414,6 +414,47 @@ loglevel_to_string(uint32_t level) > } > } > > +static int > +log_type_compare(const void *a, const void *b) > +{ > + const struct rte_log_dynamic_type *type_a = a; > + const struct rte_log_dynamic_ty

[dpdk-dev] [PATCH v6 4/4] log: add option argument help

2021-04-06 Thread Thomas Monjalon
The option --log-level was not completely described in the usage text, and it was difficult to guess the names of the log types and levels. A new value "help" is accepted after --log-level to give more details about the syntax and listing the log types and levels. The array "levels" used for leve