Re: [dpdk-dev] [PATCH v6 24/70] mempool: add support for the new allocation methods

2018-04-11 Thread Burakov, Anatoly
On 11-Apr-18 3:43 PM, Andrew Rybchenko wrote: On 04/11/2018 03:29 PM, Anatoly Burakov wrote: If a user has specified that the zone should have contiguous memory, use the new _contig allocation API's instead of normal ones. Just one minor nit.. As I understand _contig above is an artefact of th

Re: [dpdk-dev] [PATCH v6 24/70] mempool: add support for the new allocation methods

2018-04-11 Thread Andrew Rybchenko
On 04/11/2018 03:29 PM, Anatoly Burakov wrote: If a user has specified that the zone should have contiguous memory, use the new _contig allocation API's instead of normal ones. Just one minor nit.. As I understand _contig above is an artefact of the previous approach with dedicated function for

Re: [dpdk-dev] [PATCH v6 24/70] mempool: add support for the new allocation methods

2018-04-11 Thread Olivier Matz
On Wed, Apr 11, 2018 at 01:29:59PM +0100, Anatoly Burakov wrote: > If a user has specified that the zone should have contiguous memory, > use the new _contig allocation API's instead of normal ones. > Otherwise, account for the fact that unless we're in IOVA_AS_VA > mode, we cannot guarantee that t

Re: [dpdk-dev] [PATCH v6 24/70] mempool: add support for the new allocation methods

2018-04-11 Thread Olivier Matz
On Wed, Apr 11, 2018 at 01:29:59PM +0100, Anatoly Burakov wrote: > If a user has specified that the zone should have contiguous memory, > use the new _contig allocation API's instead of normal ones. > Otherwise, account for the fact that unless we're in IOVA_AS_VA > mode, we cannot guarantee that t

[dpdk-dev] [PATCH v6 24/70] mempool: add support for the new allocation methods

2018-04-11 Thread Anatoly Burakov
If a user has specified that the zone should have contiguous memory, use the new _contig allocation API's instead of normal ones. Otherwise, account for the fact that unless we're in IOVA_AS_VA mode, we cannot guarantee that the pages would be physically contiguous, so we calculate the memzone size