Re: [dpdk-dev] [PATCH v6 2/4] lib: add bitrate statistics library

2017-01-16 Thread Remy Horton
On 11/01/2017 16:15, Stephen Hemminger wrote: [..] You want these statistics to be cache aligned (ie not 0) to avoid false cache sharing. Done. Since these statistics are often associated with a device would it not make sense to have a NUMA socket associated with the alllocation? Makes sens

Re: [dpdk-dev] [PATCH v6 2/4] lib: add bitrate statistics library

2017-01-11 Thread Stephen Hemminger
On Thu, 12 Jan 2017 00:03:12 +0800 Remy Horton wrote: > + > +struct rte_stats_bitrates_s * > +rte_stats_bitrate_create(void) > +{ > + return rte_zmalloc(NULL, sizeof(struct rte_stats_bitrates_s), 0); > +} > + You want these statistics to be cache aligned (ie not 0) to avoid false cache shari

[dpdk-dev] [PATCH v6 2/4] lib: add bitrate statistics library

2017-01-11 Thread Remy Horton
This patch adds a library that calculates peak and average data-rate statistics. For ethernet devices. These statistics are reported using the metrics library. Signed-off-by: Remy Horton --- MAINTAINERS| 4 + config/common_base