Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Burakov, Anatoly
On 28-Mar-18 12:26 PM, Thomas Monjalon wrote: 28/03/2018 12:42, Burakov, Anatoly: On 28-Mar-18 10:53 AM, Thomas Monjalon wrote: 28/03/2018 11:21, Burakov, Anatoly: I'm not against trying to improve the core design. I'm just saying that, had this kind of feedback been provided just a bit earlie

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Thomas Monjalon
28/03/2018 12:42, Burakov, Anatoly: > On 28-Mar-18 10:53 AM, Thomas Monjalon wrote: > > 28/03/2018 11:21, Burakov, Anatoly: > >> so i don't think > >> it's such a big deal to have two IPC threads instead of one. I'm open to > >> suggestions on how to make this work without a second thread, but i >

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Burakov, Anatoly
On 28-Mar-18 10:53 AM, Thomas Monjalon wrote: 28/03/2018 11:21, Burakov, Anatoly: On 28-Mar-18 9:55 AM, Tan, Jianfeng wrote: On 3/28/2018 4:22 PM, Van Haaren, Harry wrote: From: Thomas Monjalon [mailto:tho...@monjalon.net] 28/03/2018 04:08, Tan, Jianfeng: From: Thomas Monjalon [mailto:tho...

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Thomas Monjalon
28/03/2018 11:21, Burakov, Anatoly: > On 28-Mar-18 9:55 AM, Tan, Jianfeng wrote: > > On 3/28/2018 4:22 PM, Van Haaren, Harry wrote: > >> From: Thomas Monjalon [mailto:tho...@monjalon.net] > >>> 28/03/2018 04:08, Tan, Jianfeng: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 27/03/

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Burakov, Anatoly
, Harry Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC 28/03/2018 04:08, Tan, Jianfeng: Hi Thomas , From: Thomas Monjalon [mailto:tho...@monjalon.net] 27/03/2018 15:59, Anatoly Burakov: Under the hood, we create a separate thread to deal with replies to

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Bruce Richardson
On Wed, Mar 28, 2018 at 09:29:35AM +0200, Thomas Monjalon wrote: > 28/03/2018 04:08, Tan, Jianfeng: > > Hi Thomas , > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 27/03/2018 15:59, Anatoly Burakov: > > > > Under the hood, we create a separate thread to deal with replies to > > >

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Van Haaren, Harry
> -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, March 28, 2018 9:55 AM > To: Van Haaren, Harry ; Thomas Monjalon > > Cc: Burakov, Anatoly ; dev@dpdk.org; Ananyev, > Konstantin > Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request A

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Tan, Jianfeng
] eal: add asynchronous request API to DPDK IPC 28/03/2018 04:08, Tan, Jianfeng: Hi Thomas , From: Thomas Monjalon [mailto:tho...@monjalon.net] 27/03/2018 15:59, Anatoly Burakov: Under the hood, we create a separate thread to deal with replies to asynchronous requests, that will just wait to be

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Van Haaren, Harry
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, March 28, 2018 8:30 AM > To: Tan, Jianfeng > Cc: Burakov, Anatoly ; dev@dpdk.org; Ananyev, > Konstantin ; Van Haaren, Harry > > Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-28 Thread Thomas Monjalon
28/03/2018 04:08, Tan, Jianfeng: > Hi Thomas , > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 27/03/2018 15:59, Anatoly Burakov: > > > Under the hood, we create a separate thread to deal with replies to > > > asynchronous requests, that will just wait to be notified by the > > > main t

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-27 Thread Tan, Jianfeng
Hi Thomas , > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, March 28, 2018 12:34 AM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Tan, Jianfeng; Ananyev, Konstantin; Van Haaren, Harry > Subject: Re: [dpdk-dev] [PATCH v6 2/2] eal

Re: [dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-27 Thread Thomas Monjalon
27/03/2018 15:59, Anatoly Burakov: > Under the hood, we create a separate thread to deal with replies to > asynchronous requests, that will just wait to be notified by the > main thread, or woken up on a timer. I really don't like that a library is creating a thread. We don't even know where the t

[dpdk-dev] [PATCH v6 2/2] eal: add asynchronous request API to DPDK IPC

2018-03-27 Thread Anatoly Burakov
This API is similar to the blocking API that is already present, but reply will be received in a separate callback by the caller (callback specified at the time of request, rather than registering for it in advance). Under the hood, we create a separate thread to deal with replies to asynchronous