Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Thomas Monjalon
26/04/2018 22:07, Olivier Matz: > On Thu, Apr 26, 2018 at 09:58:00PM +0200, Thomas Monjalon wrote: > > 26/04/2018 21:42, Olivier Matz: > > > On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > > > > 26/04/2018 18:05, Andrew Rybchenko: > > > > > On 04/26/2018 04:10 AM, Yongseok Koh wr

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Olivier Matz
On Thu, Apr 26, 2018 at 09:58:00PM +0200, Thomas Monjalon wrote: > 26/04/2018 21:42, Olivier Matz: > > On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > > > 26/04/2018 18:05, Andrew Rybchenko: > > > > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > > > > -#define RTE_MBUF_INDIRECT(

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Thomas Monjalon
26/04/2018 21:42, Olivier Matz: > On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > > 26/04/2018 18:05, Andrew Rybchenko: > > > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > > +#define RTE_MBUF_INDIRE

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Olivier Matz
On Thu, Apr 26, 2018 at 10:18:14AM -0700, Yongseok Koh wrote: > [...] > > > /** Mbuf prefetch */ > > > #define RTE_MBUF_PREFETCH_TO_FREE(m) do { \ > > > if ((m) != NULL)\ > > > @@ -1213,11 +1307,157 @@ static inline int rte_pktmbuf_alloc_bulk(struct >

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Olivier Matz
On Thu, Apr 26, 2018 at 06:10:36PM +0200, Thomas Monjalon wrote: > 26/04/2018 18:05, Andrew Rybchenko: > > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > > +#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > > > > We h

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Yongseok Koh
On Thu, Apr 26, 2018 at 07:05:01PM +0300, Andrew Rybchenko wrote: > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > This patch introduces a new way of attaching an external buffer to a mbuf. > > > > Attaching an external buffer is quite similar to mbuf indirection in > > replacing buffer addresses

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Thomas Monjalon
26/04/2018 18:05, Andrew Rybchenko: > On 04/26/2018 04:10 AM, Yongseok Koh wrote: > > -#define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTACHED_MBUF) > > +#define RTE_MBUF_INDIRECT(mb) RTE_MBUF_CLONED(mb) > > We have discussed that it would be good to deprecate RTE_MBUF_INDIRECT() > since

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Andrew Rybchenko
On 04/26/2018 04:10 AM, Yongseok Koh wrote: This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attach

Re: [dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-26 Thread Ananyev, Konstantin
> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Thursday, April 26, 2018 2:10 AM > To: Lu, Wenzhuo ; Wu, Jingjing ; > olivier.m...@6wind.com > Cc: dev@dpdk.org; Ananyev, Konstantin ; > arybche...@solarflare.com; step...@networkplumber.org; > tho...@monjalon

[dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attached, refcnt of the direct mbuf would be 2 as