[dpdk-dev] [PATCH v6 08/10] hash: remove duplicated code

2015-06-16 Thread Thomas Monjalon
2015-06-16 10:31, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > The following patch is needed and will be squashed to fix some doxygen > > issues: |...] |> Thanks for spotting this! > Are you going to do it yourself or you want me to do it and send a v7?

[dpdk-dev] [PATCH v6 08/10] hash: remove duplicated code

2015-06-16 Thread Thomas Monjalon
The following patch is needed and will be squashed to fix some doxygen issues: --- a/lib/librte_hash/rte_jhash.h +++ b/lib/librte_hash/rte_jhash.h @@ -306,13 +306,13 @@ rte_jhash2(const uint32_t *k, uint32_t length, uint32_t initval) * with seeds. If you pass in (*pb)=0, the output (*pc) will b

[dpdk-dev] [PATCH v6 08/10] hash: remove duplicated code

2015-06-16 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, June 16, 2015 10:33 AM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 08/10] hash: remove duplicated code > >

[dpdk-dev] [PATCH v6 08/10] hash: remove duplicated code

2015-06-10 Thread Pablo de Lara
rte_jhash is basically like __rte_jhash_2hashes but it returns only 1 hash, instead of 2. In order to remove duplicated code, rte_jhash calls __rte_jhash_2hashes, passing 0 as the second seed and returning just the first hash value. (performance penalty is negligible) The same is done with rte_jha