Re: [dpdk-dev] [PATCH v6 02/25] ethdev: add a link status text representation

2020-07-06 Thread Stephen Hemminger
On Mon, 6 Jul 2020 23:37:16 +0300 Ivan Dyukov wrote: > + /* Error cases */ > + default: > + return -1; > + Since very little of the code is checking for errors, why return on bad format. Why not do what printf() does and ignore

Re: [dpdk-dev] [PATCH v6 02/25] ethdev: add a link status text representation

2020-07-06 Thread Stephen Hemminger
On Mon, 6 Jul 2020 23:37:16 +0300 Ivan Dyukov wrote: > static int > +rte_eth_link_strf_parser(char *str, size_t len, const char *const fmt, > +struct rte_eth_link *link) The link arg should be const. > +{ > + size_t offset = 0; > + const char *fmt_cur = fmt; > +

[dpdk-dev] [PATCH v6 02/25] ethdev: add a link status text representation

2020-07-06 Thread Ivan Dyukov
This commit add function which treat link status structure and format it to text representation. Signed-off-by: Ivan Dyukov --- MAINTAINERS | 1 + app/test/Makefile| 3 + app/test/meson.build | 2 + app/test/test_ethd