Re: [dpdk-dev] [PATCH v6 01/19] vhost: fix messages results handling

2018-10-12 Thread Maxime Coquelin
On 10/12/2018 11:03 AM, Maxime Coquelin wrote: On 10/11/2018 06:18 PM, Ilya Maximets wrote: On 11.10.2018 12:24, Maxime Coquelin wrote: Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking t

Re: [dpdk-dev] [PATCH v6 01/19] vhost: fix messages results handling

2018-10-12 Thread Maxime Coquelin
On 10/11/2018 06:18 PM, Ilya Maximets wrote: On 11.10.2018 12:24, Maxime Coquelin wrote: Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leadi

Re: [dpdk-dev] [PATCH v6 01/19] vhost: fix messages results handling

2018-10-11 Thread Ilya Maximets
On 11.10.2018 12:24, Maxime Coquelin wrote: > Return of message handling has now changed to an enum that can > take non-negative value that is not zero in case a reply is > needed. But the code checking the variable afterwards has not > been updated, leading to success messages handling being > tre

[dpdk-dev] [PATCH v6 01/19] vhost: fix messages results handling

2018-10-11 Thread Maxime Coquelin
Return of message handling has now changed to an enum that can take non-negative value that is not zero in case a reply is needed. But the code checking the variable afterwards has not been updated, leading to success messages handling being treated as errors. External post and pre callbacks retur