Re: [dpdk-dev] [PATCH v6] sched: make RED scaling configurable

2018-01-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Alan Dewar [mailto:alangordonde...@gmail.com] > Sent: Tuesday, January 16, 2018 3:58 PM > To: Stephen Hemminger > Cc: Dumitrescu, Cristian ; Kantecki, Tomasz > ; Singh, Jasvinder > ; dev@dpdk.org; Alan Dewar > > Subject: Re:

Re: [dpdk-dev] [PATCH v6] sched: make RED scaling configurable

2018-01-16 Thread Alan Dewar
On Tue, Jan 16, 2018 at 3:50 PM, Alan Dewar wrote: > On Mon, Jan 15, 2018 at 4:52 PM, Stephen Hemminger > wrote: >> >> On Mon, 15 Jan 2018 16:16:09 + >> alangordonde...@gmail.com wrote: >> >> Looks like a good idea, minor editing feedback. >> >> >> > - red_cfg->min_th = ((uint32_t) min_th

Re: [dpdk-dev] [PATCH v6] sched: make RED scaling configurable

2018-01-16 Thread Alan Dewar
On Mon, Jan 15, 2018 at 4:52 PM, Stephen Hemminger wrote: > > On Mon, 15 Jan 2018 16:16:09 + > alangordonde...@gmail.com wrote: > > Looks like a good idea, minor editing feedback. > > > > - red_cfg->min_th = ((uint32_t) min_th) << (wq_log2 + RTE_RED_SCALING); > > - red_cfg->max_th = ((

Re: [dpdk-dev] [PATCH v6] sched: make RED scaling configurable

2018-01-15 Thread Stephen Hemminger
On Mon, 15 Jan 2018 16:16:09 + alangordonde...@gmail.com wrote: Looks like a good idea, minor editing feedback. > - red_cfg->min_th = ((uint32_t) min_th) << (wq_log2 + RTE_RED_SCALING); > - red_cfg->max_th = ((uint32_t) max_th) << (wq_log2 + RTE_RED_SCALING); > - red_cfg->pa_cons

[dpdk-dev] [PATCH v6] sched: make RED scaling configurable

2018-01-15 Thread alangordondewar
From: Alan Dewar The RED code stores the weighted moving average in a 32-bit integer as a pseudo fixed-point floating number with 10 fractional bits. Twelve other bits are used to encode the filter weight, leaving just 10 bits for the queue length. This limits the maximum queue length supported