Re: [dpdk-dev] [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition

2018-05-28 Thread Neil Horman
On Mon, May 28, 2018 at 12:01:15AM +0200, Thomas Monjalon wrote: > 27/05/2018 23:00, Neil Horman: > > On Sun, May 27, 2018 at 09:34:13PM +0200, Thomas Monjalon wrote: > > > Hi Neil, > > > > > > Sorry, this patch has been forgotten during the whole release cycle. > > > > > Its ok, though that is f

Re: [dpdk-dev] [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition

2018-05-27 Thread Thomas Monjalon
27/05/2018 23:00, Neil Horman: > On Sun, May 27, 2018 at 09:34:13PM +0200, Thomas Monjalon wrote: > > Hi Neil, > > > > Sorry, this patch has been forgotten during the whole release cycle. > > > Its ok, though that is frustrating, as we now need to re-familiarize ourselves > with how this patch wo

Re: [dpdk-dev] [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition

2018-05-27 Thread Neil Horman
On Sun, May 27, 2018 at 09:34:13PM +0200, Thomas Monjalon wrote: > Hi Neil, > > Sorry, this patch has been forgotten during the whole release cycle. > Its ok, though that is frustrating, as we now need to re-familiarize ourselves with how this patch works. > I see an issue about the dependency o

Re: [dpdk-dev] [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition

2018-05-27 Thread Thomas Monjalon
Hi Neil, Sorry, this patch has been forgotten during the whole release cycle. I see an issue about the dependency on filterdiff. Is there a way to avoid it? I have some minor comments below. 14/02/2018 20:19, Neil Horman: > @@ -61,6 +65,7 @@ print_usage () { > END_OF_HELP > } > > + Th

[dpdk-dev] [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition

2018-02-14 Thread Neil Horman
Recently, some additional patches were added to allow for programmatic marking of C symbols as experimental. The addition of these markers is dependent on the manual addition of exported symbols to the EXPERIMENTAL section of the corresponding libraries version map file. The consensus on review i