Re: [dpdk-dev] [PATCH v5 4/9] eal: hide shared memory config

2019-07-08 Thread Thomas Monjalon
08/07/2019 11:22, Burakov, Anatoly: > On 05-Jul-19 8:08 PM, Thomas Monjalon wrote: > > 05/07/2019 19:26, Anatoly Burakov: > >> --- a/lib/librte_eal/common/include/rte_fbarray.h > >> +++ b/lib/librte_eal/common/include/rte_fbarray.h > >> @@ -34,7 +34,6 @@ > >> extern "C" { > >> #endif > >> >

Re: [dpdk-dev] [PATCH v5 4/9] eal: hide shared memory config

2019-07-08 Thread Burakov, Anatoly
On 05-Jul-19 8:08 PM, Thomas Monjalon wrote: 05/07/2019 19:26, Anatoly Burakov: --- a/lib/librte_eal/common/include/rte_fbarray.h +++ b/lib/librte_eal/common/include/rte_fbarray.h @@ -34,7 +34,6 @@ extern "C" { #endif -#include #include It triggers some compilation errors in mlx4 a

Re: [dpdk-dev] [PATCH v5 4/9] eal: hide shared memory config

2019-07-05 Thread Thomas Monjalon
05/07/2019 19:26, Anatoly Burakov: > --- a/lib/librte_eal/common/include/rte_fbarray.h > +++ b/lib/librte_eal/common/include/rte_fbarray.h > @@ -34,7 +34,6 @@ > extern "C" { > #endif > > -#include > #include It triggers some compilation errors in mlx4 and mlx5: fatal error: unknown

[dpdk-dev] [PATCH v5 4/9] eal: hide shared memory config

2019-07-05 Thread Anatoly Burakov
Now that everything that has ever accessed the shared memory config is doing so through the public API's, we can make it internal. Since we're removing quite a few headers from rte_eal_memconfig.h, we need to add them back in places where this header is used. This bumps the ABI, so also change all