Re: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-09 Thread Shreyansh Jain
On Tuesday 10 April 2018 11:39 AM, Remy Horton wrote: On 10/04/2018 05:18, Shreyansh Jain wrote: [..] I'll add in the snippet above. 18.05 integration deadline has I think passed, but documentation changes will still get in. @thomas you won't be integrating these default conf patches in 18.05

Re: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-09 Thread Remy Horton
On 10/04/2018 05:18, Shreyansh Jain wrote: [..] I'll add in the snippet above. 18.05 integration deadline has I think passed, but documentation changes will still get in. @thomas you won't be integrating these default conf patches in 18.05? I meant that since the v5 and v6 will only differ

Re: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-09 Thread Shreyansh Jain
e: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx > parameters > > [...] > > > > If you add that, please use my ack for next revision. > > (For patch 1/4, I had already given my Ack in v2) > > I'll add in the snippet above. 18.05 integration deadli

Re: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-09 Thread Remy Horton
On 09/04/2018 13:55, Shreyansh Jain wrote: [..] Documentation for burst mode changes to testpmd would need an update. I guess, only when the user explicitly sets 'set burst 0' would the driver defaults be picked up - isn't it? Yes. Maybe something like this: --->8--- --- a/doc/guides/testp

Re: [dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-09 Thread Shreyansh Jain
On Friday 06 April 2018 08:20 PM, Remy Horton wrote: The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows testpmd to make use of per-PMD tu

[dpdk-dev] [PATCH v5 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-06 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows testpmd to make use of per-PMD tuned parameter values. Signed-off-by: Remy Horton ---