Re: [dpdk-dev] [PATCH v5 3/3] ipfrag: add unit test case

2020-04-25 Thread Thomas Monjalon
20/04/2020 19:34, Aaron Conole: > "Burakov, Anatoly" writes: > > Nitpicking, but i believe the coding style guide discourages using > > boolean syntax for anything other than boolean checks, and it is > > better to use a more explicit `if (x == NULL)`. > > I see, it does. Looking at the code-bas

Re: [dpdk-dev] [PATCH v5 3/3] ipfrag: add unit test case

2020-04-20 Thread Aaron Conole
"Burakov, Anatoly" writes: > On 17-Apr-20 2:14 PM, Aaron Conole wrote: >> Initial IP fragmentation unit test. >> >> Signed-off-by: Aaron Conole >> --- > > > >> +if (!pkt_pool) >> +pkt_pool = rte_pktmbuf_pool_create("FRAG_MBUF_POOL", >> +

Re: [dpdk-dev] [PATCH v5 3/3] ipfrag: add unit test case

2020-04-20 Thread Burakov, Anatoly
On 17-Apr-20 2:14 PM, Aaron Conole wrote: Initial IP fragmentation unit test. Signed-off-by: Aaron Conole --- + if (!pkt_pool) + pkt_pool = rte_pktmbuf_pool_create("FRAG_MBUF_POOL", + NUM_MBUFS, BURST, 0, +

Re: [dpdk-dev] [PATCH v5 3/3] ipfrag: add unit test case

2020-04-17 Thread Lukasz Wojciechowski
W dniu 17.04.2020 o 15:14, Aaron Conole pisze: > Initial IP fragmentation unit test. > > Signed-off-by: Aaron Conole > --- > MAINTAINERS| 1 + > app/test/meson.build | 2 + > app/test/test_ipfrag.c | 272 + > 3 files changed, 275 ins

[dpdk-dev] [PATCH v5 3/3] ipfrag: add unit test case

2020-04-17 Thread Aaron Conole
Initial IP fragmentation unit test. Signed-off-by: Aaron Conole --- MAINTAINERS| 1 + app/test/meson.build | 2 + app/test/test_ipfrag.c | 272 + 3 files changed, 275 insertions(+) create mode 100644 app/test/test_ipfrag.c diff --git a/