Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-19 Thread fengchengwen
On 2021/5/19 20:37, David Marchand wrote: > On Wed, May 19, 2021 at 2:17 PM fengchengwen wrote: >> We also found compile error with gcc8.3 with arm64_kunpeng930_linux_gcc >> (-march=-march=armv8.2-a+crypto+sve): >> In file included from >> ../dpdk-next-net/lib/eal/common/eal_common_options.

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-19 Thread David Marchand
On Wed, May 19, 2021 at 2:17 PM fengchengwen wrote: > We also found compile error with gcc8.3 with arm64_kunpeng930_linux_gcc > (-march=-march=armv8.2-a+crypto+sve): > In file included from > ../dpdk-next-net/lib/eal/common/eal_common_options.c:38: > ../dpdk-next-net/lib/eal/arm/include/rte_

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-19 Thread fengchengwen
On 2021/5/19 17:27, Ferruh Yigit wrote: > On 5/19/2021 9:08 AM, David Marchand wrote: >> On Tue, May 18, 2021 at 6:28 PM Ferruh Yigit wrote: >>> >>> On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote: > > Currently, the SVE code is compiled only when -march supports SVE (e.g. '

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-19 Thread Ferruh Yigit
On 5/19/2021 9:08 AM, David Marchand wrote: > On Tue, May 18, 2021 at 6:28 PM Ferruh Yigit wrote: >> >> On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote: >>> >>> Currently, the SVE code is compiled only when -march supports SVE (e.g. '- march=armv8.2a+sve'), there maybe some proble

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-19 Thread David Marchand
On Tue, May 18, 2021 at 6:28 PM Ferruh Yigit wrote: > > On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote: > > > > > >> > >> Currently, the SVE code is compiled only when -march supports SVE (e.g. '- > >> march=armv8.2a+sve'), there maybe some problem[1] with this approach. > >> > >> The solution:

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread fengchengwen
Thanks a lot, Ferruh & Honnappa. On 2021/5/19 0:27, Ferruh Yigit wrote: > On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote: >> >> >>> >>> Currently, the SVE code is compiled only when -march supports SVE (e.g. '- >>> march=armv8.2a+sve'), there maybe some problem[1] with this approach. >>> >>> Th

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread fengchengwen
On 2021/5/19 0:37, Ferruh Yigit wrote: > On 5/18/2021 5:12 PM, Honnappa Nagarahalli wrote: > > On 5/14/2021 10:53 AM, Chengwen Feng wrote: >> Currently, the SVE code is compiled only when -march supports SVE >> (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 5:12 PM, Honnappa Nagarahalli wrote: >>> On 5/14/2021 10:53 AM, Chengwen Feng wrote: > Currently, the SVE code is compiled only when -march supports SVE > (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > approach. > > The solution: >>

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/14/2021 3:12 PM, Honnappa Nagarahalli wrote: > > >> >> Currently, the SVE code is compiled only when -march supports SVE (e.g. '- >> march=armv8.2a+sve'), there maybe some problem[1] with this approach. >> >> The solution: >> a. If the minimum instruction set support SVE then compiles it. >>

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Honnappa Nagarahalli
> > > >> > >> On 5/14/2021 10:53 AM, Chengwen Feng wrote: > >>> Currently, the SVE code is compiled only when -march supports SVE > >>> (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > >>> approach. > >>> > >>> The solution: > >>> a. If the minimum instruction set support SVE

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 4:15 PM, Bruce Richardson wrote: > On Tue, May 18, 2021 at 03:40:18PM +0100, Ferruh Yigit wrote: >> On 5/14/2021 10:53 AM, Chengwen Feng wrote: >>> Currently, the SVE code is compiled only when -march supports SVE >>> (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 4:48 PM, Honnappa Nagarahalli wrote: > >> >> On 5/14/2021 10:53 AM, Chengwen Feng wrote: >>> Currently, the SVE code is compiled only when -march supports SVE >>> (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this >>> approach. >>> >>> The solution: >>> a. If the mini

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Honnappa Nagarahalli
> > On 5/14/2021 10:53 AM, Chengwen Feng wrote: > > Currently, the SVE code is compiled only when -march supports SVE > > (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > > approach. > > > > The solution: > > a. If the minimum instruction set support SVE then compiles it. > >

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Bruce Richardson
On Tue, May 18, 2021 at 03:40:18PM +0100, Ferruh Yigit wrote: > On 5/14/2021 10:53 AM, Chengwen Feng wrote: > > Currently, the SVE code is compiled only when -march supports SVE > > (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > > approach. > > > > The solution: > > a. If th

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/14/2021 10:53 AM, Chengwen Feng wrote: > Currently, the SVE code is compiled only when -march supports SVE > (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this > approach. > > The solution: > a. If the minimum instruction set support SVE then compiles it. > b. Else if the com

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Ferruh Yigit
On 5/18/2021 1:41 PM, fengchengwen wrote: > Hi, Thomas, Ferruh > > This patch is part of the hns3 SVE compilation solution and can work > independently. Could you review it ? > Hi Chengwen, This patch has been missed as being part of the config file set. As far as I understand you want this ch

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Honnappa Nagarahalli
> > > > > Hi, Thomas, Ferruh > > > > This patch is part of the hns3 SVE compilation solution and can work > > independently. Could you review it ? > I believe this patch is targeted for 20.08 release (as 20.05 is already close > to > completion), is my understanding correct? > If it is targeted f

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread Honnappa Nagarahalli
> > Hi, Thomas, Ferruh > > This patch is part of the hns3 SVE compilation solution and can work > independently. Could you review it ? I believe this patch is targeted for 20.08 release (as 20.05 is already close to completion), is my understanding correct? If it is targeted for 20.08, it will

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-18 Thread fengchengwen
Hi, Thomas, Ferruh This patch is part of the hns3 SVE compilation solution and can work independently. Could you review it ? Best regards On 2021/5/14 22:12, Honnappa Nagarahalli wrote: > > >> >> Currently, the SVE code is compiled only when -march supports SVE (e.g. '- >> march=armv8.2a+sve'

Re: [dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-14 Thread Honnappa Nagarahalli
> > Currently, the SVE code is compiled only when -march supports SVE (e.g. '- > march=armv8.2a+sve'), there maybe some problem[1] with this approach. > > The solution: > a. If the minimum instruction set support SVE then compiles it. > b. Else if the compiler support SVE then compiles it. > c.

[dpdk-dev] [PATCH v5 2/2] net/hns3: refactor SVE code compile method

2021-05-14 Thread Chengwen Feng
Currently, the SVE code is compiled only when -march supports SVE (e.g. '-march=armv8.2a+sve'), there maybe some problem[1] with this approach. The solution: a. If the minimum instruction set support SVE then compiles it. b. Else if the compiler support SVE then compiles it. c. Otherwise don't com