Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-10-06 Thread Xueming(Steven) Li
On Wed, 2021-10-06 at 09:04 +0100, Ferruh Yigit wrote: > On 10/6/2021 8:55 AM, Xueming(Steven) Li wrote: > > On Tue, 2021-10-05 at 17:38 +0100, Ferruh Yigit wrote: > > > On 9/29/2021 2:57 PM, Xueming(Steven) Li wrote: > > > > On Wed, 2021-09-22 at 12:54 +, Xueming(Steven) Li wrote: > > > > > On

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-10-06 Thread Ferruh Yigit
On 10/6/2021 8:55 AM, Xueming(Steven) Li wrote: On Tue, 2021-10-05 at 17:38 +0100, Ferruh Yigit wrote: On 9/29/2021 2:57 PM, Xueming(Steven) Li wrote: On Wed, 2021-09-22 at 12:54 +, Xueming(Steven) Li wrote: On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: <...> void -i40e_dev

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-10-06 Thread Xueming(Steven) Li
On Tue, 2021-10-05 at 17:38 +0100, Ferruh Yigit wrote: > On 9/29/2021 2:57 PM, Xueming(Steven) Li wrote: > > On Wed, 2021-09-22 at 12:54 +, Xueming(Steven) Li wrote: > > > On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: > > > > > > > > > > > > <...> > > > > > > > > > > > > > void > >

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-10-05 Thread Ferruh Yigit
On 9/29/2021 2:57 PM, Xueming(Steven) Li wrote: On Wed, 2021-09-22 at 12:54 +, Xueming(Steven) Li wrote: On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: <...> void -i40e_dev_rx_queue_release(void *rxq) +i40e_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) +{ +

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-29 Thread Xueming(Steven) Li
On Wed, 2021-09-22 at 12:54 +, Xueming(Steven) Li wrote: > On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: > > > > > > > > <...> > > > > > > > > > void > > > > > -i40e_dev_rx_queue_release(void *rxq) > > > > > +i40e_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) > > > > >

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-22 Thread Xueming(Steven) Li
On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: > > > > > > <...> > > > > > > > void > > > > -i40e_dev_rx_queue_release(void *rxq) > > > > +i40e_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) > > > > +{ > > > > + i40e_rx_queue_release(dev->data->rx_queues[qid]); > > > >

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-22 Thread Xueming(Steven) Li
Hi Ferruh, Appreciate for the careful check! On Tue, 2021-09-21 at 19:13 +0100, Ferruh Yigit wrote: > On 9/18/2021 1:35 PM, Xueming Li wrote: > > Currently, most ethdev callback API use queue ID as parameter, but Rx > > and Tx queue release callback use queue object which is used by Rx and > > T

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-22 Thread Ferruh Yigit
On 9/22/2021 10:35 AM, Xueming(Steven) Li wrote: > Hi Ferruh, > > Appreciate for the careful check! > > On Tue, 2021-09-21 at 19:13 +0100, Ferruh Yigit wrote: >> On 9/18/2021 1:35 PM, Xueming Li wrote: >>> Currently, most ethdev callback API use queue ID as parameter, but Rx >>> and Tx queue rel

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-21 Thread Ferruh Yigit
On 9/18/2021 1:35 PM, Xueming Li wrote: > Currently, most ethdev callback API use queue ID as parameter, but Rx > and Tx queue release callback use queue object which is used by Rx and > Tx burst data plane callback. > > To align with other eth device queue configuration callbacks: > - queue relea

[dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-18 Thread Xueming Li
Currently, most ethdev callback API use queue ID as parameter, but Rx and Tx queue release callback use queue object which is used by Rx and Tx burst data plane callback. To align with other eth device queue configuration callbacks: - queue release callbacks are changed to use queue ID - all drive