Re: [dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions

2017-10-18 Thread Aaron Conole
Gaëtan Rivet writes: > On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote: >> Gaetan Rivet writes: >> >> > Parsing operations should not happen in performance critical sections. >> > Headers should not propose implementations unless duly required. >> > >> > Signed-off-by: Gaetan Rivet

Re: [dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions

2017-10-18 Thread Gaëtan Rivet
On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote: > Gaetan Rivet writes: > > > Parsing operations should not happen in performance critical sections. > > Headers should not propose implementations unless duly required. > > > > Signed-off-by: Gaetan Rivet > > --- > > Can these cleanu

Re: [dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions

2017-10-17 Thread Aaron Conole
Gaetan Rivet writes: > Parsing operations should not happen in performance critical sections. > Headers should not propose implementations unless duly required. > > Signed-off-by: Gaetan Rivet > --- Can these cleanups be done before the move in patch 3?

[dpdk-dev] [PATCH v5 10/20] pci: avoid inlining functions

2017-10-12 Thread Gaetan Rivet
Parsing operations should not happen in performance critical sections. Headers should not propose implementations unless duly required. Signed-off-by: Gaetan Rivet --- lib/librte_pci/include/rte_pci.h | 69 -- lib/librte_pci/rte_pci.c | 65