Re: [dpdk-dev] [PATCH v5 1/4] net/tap: move private elements to external header

2017-03-21 Thread Pascal Mazon
On Tue, 21 Mar 2017 15:32:06 + "Wiles, Keith" wrote: > > Just noticed this new header does not have the C++ ifdefs. Create a > new patch to fix this problem, unless you need to update this patch > series. Just starting my review of this one, sorry was traveling last > week. > > Regards, > K

Re: [dpdk-dev] [PATCH v5 1/4] net/tap: move private elements to external header

2017-03-21 Thread Wiles, Keith
> On Mar 15, 2017, at 9:54 AM, Pascal Mazon wrote: > > In the next patch, access to struct pmd_internals will be necessary in > tap_flow.c to store the flows. > > Signed-off-by: Pascal Mazon > Acked-by: Olga Shern > --- > drivers/net/tap/Makefile | 1 + > drivers/net/tap/rte_eth_tap.c |

[dpdk-dev] [PATCH v5 1/4] net/tap: move private elements to external header

2017-03-15 Thread Pascal Mazon
In the next patch, access to struct pmd_internals will be necessary in tap_flow.c to store the flows. Signed-off-by: Pascal Mazon Acked-by: Olga Shern --- drivers/net/tap/Makefile | 1 + drivers/net/tap/rte_eth_tap.c | 36 ++--- drivers/net/tap/rte_eth_tap.h | 75 +