Re: [dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Akhil Goyal
On 10/16/2018 4:45 PM, Joseph, Anoob wrote: > Don't you need to use /** (or /*) instead of /**< when the comment is before > the member? I think the first member ('int8_t bearer') would have it right. > Rest could end up wrong. Can you try building the docs and see if it's coming > off well. I

Re: [dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Joseph, Anoob
I think the same issue is observed if you go through the following doc, https://doc.dpdk.org/api/structrte__security__ipsec__sa__options.html Check for the description of field copy_df in rte_security.h Thanks, Anoob > -Original Message----- > From: Akhil Goyal > Sent: 16 October 201

Re: [dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Akhil Goyal
Hi Anoob, On 10/16/2018 4:19 PM, Joseph, Anoob wrote: > Hi Akhil, > > The HFN threshold comment is still not right I guess, > >> +uint32_t hfn; >> +/**< HFN Threshold for key renegotiation */ >> +uint32_t hfn_threshold; > The above code snippet is there in the rte_security.

Re: [dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Joseph, Anoob
Hi Akhil, The HFN threshold comment is still not right I guess, > +uint32_t hfn; > +/**< HFN Threshold for key renegotiation */ > +uint32_t hfn_threshold; The above code snippet is there in the rte_security.rst file also. You may need to fix that also. And the following

[dpdk-dev] [PATCH v5 1/3] security: support pdcp protocol

2018-10-16 Thread Akhil Goyal
From: Akhil Goyal Packet Data Convergence Protocol (PDCP) is added in rte_security for 3GPP TS 36.323 for LTE. The patchset provide the structure definitions for configuring the PDCP sessions and relevant documentation is added. Signed-off-by: Hemant Agrawal Signed-off-by: Akhil Goyal --- do