[dpdk-dev] [PATCH v5 1/2] ethdev: remove get_reg_length callback

2016-07-04 Thread Zyta Szpak
Very good point.. this one and the other :) THere comes fixed version. 2016-07-04 12:38 GMT+02:00 Remy Horton : > > +++ b/drivers/net/cxgbe/cxgbe_ethdev.c >> @@ -934,7 +934,15 @@ static int cxgbe_get_regs(struct rte_eth_dev >> *eth_dev, >> struct port_info *pi = (struct port_info >> *)(et

[dpdk-dev] [PATCH v5 1/2] ethdev: remove get_reg_length callback

2016-07-04 Thread Remy Horton
> +++ b/drivers/net/cxgbe/cxgbe_ethdev.c > @@ -934,7 +934,15 @@ static int cxgbe_get_regs(struct rte_eth_dev *eth_dev, > struct port_info *pi = (struct port_info *)(eth_dev->data->dev_private); > struct adapter *adapter = pi->adapter; > > - regs->length = cxgbe_get_regs_len(eth_dev

[dpdk-dev] [PATCH v5 1/2] ethdev: remove get_reg_length callback

2016-07-04 Thread Zyta Szpak
From: Zyta Szpak Removes hard-coded assumption that device registers are always 32 bits wide. The rte_eth_dev_get_reg_length and rte_eth_dev_get_reg_info callbacks did not provide register size to the app in any way while is needed to allocate correct number of bytes before retrieving registers u