Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-25 Thread Thomas Monjalon
25/10/2019 21:01, Ori Kam: > From: Thomas Monjalon > > 24/10/2019 17:30, Andrew Rybchenko: > > > On 10/24/19 6:17 PM, Thomas Monjalon wrote: > > > > 24/10/2019 16:47, Andrew Rybchenko: > > > >> On 10/24/19 11:29 AM, Ori Kam wrote: > > > >>> Hi Andrew, > > > >>> > > > >>> When writing the new funct

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-25 Thread Ori Kam
Hi Andrew, Thomas > -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 24, 2019 6:35 PM > To: Andrew Rybchenko > Cc: dev@dpdk.org; Ori Kam ; Ferruh Yigit > ; jingjing...@intel.com; > step...@networkplumber.org > Subject: Re: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Thomas Monjalon
24/10/2019 17:30, Andrew Rybchenko: > On 10/24/19 6:17 PM, Thomas Monjalon wrote: > > 24/10/2019 16:47, Andrew Rybchenko: > >> On 10/24/19 11:29 AM, Ori Kam wrote: > >>> Hi Andrew, > >>> > >>> When writing the new function I thought about using bool, but > >>> I decided against it for the following

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Andrew Rybchenko
On 10/24/19 6:17 PM, Thomas Monjalon wrote: 24/10/2019 16:47, Andrew Rybchenko: On 10/24/19 11:29 AM, Ori Kam wrote: Hi Andrew, When writing the new function I thought about using bool, but I decided against it for the following reasons: 1. There is no use of bool any where in the code, and th

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Thomas Monjalon
24/10/2019 16:47, Andrew Rybchenko: > On 10/24/19 11:29 AM, Ori Kam wrote: > > Hi Andrew, > > > > When writing the new function I thought about using bool, but > > I decided against it for the following reasons: > > 1. There is no use of bool any where in the code, and there is not special > > rea

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Andrew Rybchenko
@dpdk.org; jingjing...@intel.com; step...@networkplumber.org Subject: Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue Hi Ori, thanks for review notes applied. Please, see below. On 10/23/19 4:37 PM, Ori Kam wrote: This commit introduce hairpin queue type. The hairpin queue in

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Ori Kam
t; Subject: Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue > > Hi Ori, > > thanks for review notes applied. Please, see below. > > On 10/23/19 4:37 PM, Ori Kam wrote: > > This commit introduce hairpin queue type. > > > > The hairpin queue

Re: [dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-24 Thread Andrew Rybchenko
Hi Ori, thanks for review notes applied. Please, see below. On 10/23/19 4:37 PM, Ori Kam wrote: This commit introduce hairpin queue type. The hairpin queue in build from Rx queue binded to Tx queue. It is used to offload traffic coming from the wire and redirect it back to the wire. There are

[dpdk-dev] [PATCH v5 02/15] ethdev: add support for hairpin queue

2019-10-23 Thread Ori Kam
This commit introduce hairpin queue type. The hairpin queue in build from Rx queue binded to Tx queue. It is used to offload traffic coming from the wire and redirect it back to the wire. There are 3 new functions: - rte_eth_dev_hairpin_capability_get - rte_eth_rx_hairpin_queue_setup - rte_eth_tx