Re: [dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-22 Thread Laatz, Kevin
Hi Mattias, Thanks for the input and clarification. I will include these changes in the v6. Regards, Kevin On 22/10/2018 08:11, Mattias Rönnblom wrote: On 2018-10-19 12:16, Laatz, Kevin wrote: On 03/10/2018 20:06, Mattias Rönnblom wrote: On 2018-10-03 19:36, Kevin Laatz wrote: From: Ciara

Re: [dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-22 Thread Mattias Rönnblom
On 2018-10-19 12:16, Laatz, Kevin wrote: On 03/10/2018 20:06, Mattias Rönnblom wrote: On 2018-10-03 19:36, Kevin Laatz wrote: From: Ciara Power + +    if (!telemetry->request_client) { +    TELEMETRY_LOG_ERR("No client has been chosen to write to"); +    return -1; +    } > + +    if (

Re: [dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-19 Thread Laatz, Kevin
Hi Mattias, On 18/10/2018 09:07, Mattias Rönnblom wrote: Most of the issues I pointed out in v2 of this patchset is still here. Will recheck feedback for the next version. With regards to comments on v2, 3/10, could you please help provide clarification on the below? On 03/10/2018 20:06,

Re: [dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-18 Thread Mattias Rönnblom
Most of the issues I pointed out in v2 of this patchset is still here. On 2018-10-16 17:57, Kevin Laatz wrote: This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a s

[dpdk-dev] [PATCH v5 00/13] introduce telemetry library

2018-10-16 Thread Kevin Laatz
This patchset introduces a Telemetry library for DPDK Service Assurance. This library provides an easy way to query DPDK Ethdev metrics. The telemetry library provides a method for a service assurance component to retrieve metrics from a DPDK packet forwarding application. Communicating from the s