Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-04-01 Thread Thomas Monjalon
02/04/2019 02:27, Thomas Monjalon: > 27/02/2019 18:19, Junjie Wan: > > From: junka > > > > The bitmap will help maintain the metrics. We can dynamically > > add and remove metrics data. For example, after uninit latency lib, > > it could remove itself from the metrics. This could make the result

Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-04-01 Thread Thomas Monjalon
27/02/2019 18:19, Junjie Wan: > From: junka > > The bitmap will help maintain the metrics. We can dynamically > add and remove metrics data. For example, after uninit latency lib, > it could remove itself from the metrics. This could make the result > from rte_metrics_get_names much more simple t

Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-02-28 Thread Remy Horton
On 28/02/2019 13:28, Wan Junjie wrote: Bitratestats test fails even without my patch. The reason is that metrics lib has no de-init process. Harman Kalra has submited a patch for this. Check https://patches.dpdk.org/patch/50451 Ah forgot about that patch. :S As for metrics lib, the array

Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-02-28 Thread Wan Junjie
Bitratestats test fails even without my patch. The reason is that metrics lib has no de-init process. Harman Kalra has submited a patch for this. Check https://patches.dpdk.org/patch/50451 As for metrics lib, the array block of metadata may be better on cache side. Since rte_metrics_update_va

Re: [dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-02-28 Thread Remy Horton
The tests for metrics themselves now all pass, but there is failure with bitrate statistics (bitrate stats uses metrics underneath). Latency statistics, which also uses metrics, seems ok though. RTE>>bitratestats_autotest + --- + + Test Suit

[dpdk-dev] [PATCH v5] lib/metrics: add unregister api for metrics

2019-02-27 Thread Junjie Wan
From: junka The bitmap will help maintain the metrics. We can dynamically add and remove metrics data. For example, after uninit latency lib, it could remove itself from the metrics. This could make the result from rte_metrics_get_names much more simple to display the wanted metrics data only. S