Re: [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function

2019-01-01 Thread Xu, Rosen
Hi Ferruh, I have added Macro to identify the dependency of ifpga, and checked it ok in my v6 patch. Pls review, thanks a lot. > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, December 20, 2018 22:23 > To: Xu, Rosen ; Iremonger, Bernard > ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu

Re: [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function

2018-12-20 Thread Ferruh Yigit
On 12/20/2018 10:48 AM, Xu, Rosen wrote: > Thanks a lot Ferruh. Sorry for the confusion Rosen, I dropped it back because of the dependency it creates to ifpga, and a put a comment to the patch. Also this gives meson build error, fyi. > >> -Original Message- >> From: Yigit, Ferruh >> Sen

Re: [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function

2018-12-20 Thread Ferruh Yigit
On 12/18/2018 11:30 AM, Rosen Xu wrote: > @@ -11,6 +11,7 @@ > > #include > #include > #include > +#include This adds dependency to ifpga for testpmd. What happen if ifpga is disabled? Will testpmd build fail? Is there a way to prevent this dependency? If not I think it should be added with co

Re: [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function

2018-12-20 Thread Xu, Rosen
Thanks a lot Ferruh. > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, December 20, 2018 16:59 > To: Iremonger, Bernard ; Xu, Rosen > ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > > Subject: Re: [PATCH v5] app/testpmd: add IFPGA AFU register access function > > On 12/18/20

Re: [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function

2018-12-20 Thread Ferruh Yigit
On 12/18/2018 6:12 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Xu, Rosen >> Sent: Tuesday, December 18, 2018 11:30 AM >> To: dev@dpdk.org >> Cc: Lu, Wenzhuo ; Wu, Jingjing >> ; Iremonger, Bernard >> ; Xu, Rosen ; Yigit, >> Ferruh >> Subject: [PATCH v5] app/testpmd: add IFP

Re: [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function

2018-12-18 Thread Iremonger, Bernard
> -Original Message- > From: Xu, Rosen > Sent: Tuesday, December 18, 2018 11:30 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > ; Xu, Rosen ; Yigit, > Ferruh > Subject: [PATCH v5] app/testpmd: add IFPGA AFU register access function > > Currently register re

[dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function

2018-12-18 Thread Rosen Xu
Currently register read/write of testpmd is only for PCI device, but more and more IFPGA based AFU devices need this feature to access registers, this patch will add support for it. Signed-off-by: Rosen Xu --- app/test-pmd/config.c | 116 - app/te