Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Ananyev, Konstantin
> 04/10/2021 15:56, Konstantin Ananyev: > > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > > data into private header (ethdev_driver.h). > [...] > > +/** > > + * @internal > > + * Structure used to hold information about the callbacks to be called for > > a > > + * qu

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Thomas Monjalon
05/10/2021 18:19, Ananyev, Konstantin: > > 04/10/2021 15:56, Konstantin Ananyev: > > > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > > > data into private header (ethdev_driver.h). > > [...] > > > +/** > > > + * @internal > > > + * Structure used to hold information about

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Ananyev, Konstantin
> > On Tue, Oct 5, 2021 at 12:43 PM Ferruh Yigit wrote: > > > This change is going to hurt a lot of people :-). > > > But this is a necessary move. > > > > > > > +1 that it is necessary move, but I am surprised to see how much > > 'rte_eth_devices' > > is accessed directly. > > > > Do you have

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Thomas Monjalon
04/10/2021 15:56, Konstantin Ananyev: > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > data into private header (ethdev_driver.h). [...] > +/** > + * @internal > + * Structure used to hold information about the callbacks to be called for a > + * queue on RX and TX. > + */ >

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread David Marchand
On Tue, Oct 5, 2021 at 12:43 PM Ferruh Yigit wrote: > > This change is going to hurt a lot of people :-). > > But this is a necessary move. > > > > +1 that it is necessary move, but I am surprised to see how much > 'rte_eth_devices' > is accessed directly. > > Do you have any idea/suggestion on h

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread Ferruh Yigit
On 10/5/2021 11:04 AM, David Marchand wrote: On Mon, Oct 4, 2021 at 3:59 PM Konstantin Ananyev wrote: Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related data into private header (ethdev_driver.h). Few minor changes to keep DPDK building after that. This change is going to

Re: [dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-05 Thread David Marchand
On Mon, Oct 4, 2021 at 3:59 PM Konstantin Ananyev wrote: > > Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related > data into private header (ethdev_driver.h). > Few minor changes to keep DPDK building after that. This change is going to hurt a lot of people :-). But this is a ne

[dpdk-dev] [PATCH v4 7/7] ethdev: hide eth dev related structures

2021-10-04 Thread Konstantin Ananyev
Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related data into private header (ethdev_driver.h). Few minor changes to keep DPDK building after that. Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_21_11.rst| 6 + drivers/common/octeontx2/otx2_sec_ide