Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, July 9, 2019 12:43 > To: Ruifeng Wang (Arm Technology China) ; > vladimir.medved...@intel.com; bruce.richard...@intel.com > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > Honnappa Nagarahalli ; nd > ; nd > Subject

Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

> > > > > > > > Compiler could generate non-atomic stores for whole table entry updating. > > > This may cause incorrect nexthop to be returned, if the byte with > > > valid flag is updated prior to the byte with next hot is updated. > >^^

Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

Hi Honnappa, > -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, July 8, 2019 12:57 > To: Ruifeng Wang (Arm Technology China) ; > vladimir.medved...@intel.com; bruce.richard...@intel.com > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > nd ; Ruifeng Wang (Arm Technolog

Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

Hi Vladimir, > -Original Message- > From: Medvedkin, Vladimir > Sent: Saturday, July 6, 2019 00:53 > To: Ruifeng Wang (Arm Technology China) ; > bruce.richard...@intel.com > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; Gavin Hu (Arm Technology China) > ; nd > Subject: Re: [PATCH v4 3/3] li

Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

> > Compiler could generate non-atomic stores for whole table entry updating. > This may cause incorrect nexthop to be returned, if the byte with valid flag > is > updated prior to the byte with next hot is updated. ^^^ Should be next

Re: [dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

Hi Wang, On 03/07/2019 06:44, Ruifeng Wang wrote: Compiler could generate non-atomic stores for whole table entry updating. This may cause incorrect nexthop to be returned, if the byte with valid flag is updated prior to the byte with next hot is updated. Changed to use atomic store to update w

[dpdk-dev] [PATCH v4 3/3] lib/lpm: use atomic store to avoid partial update

Compiler could generate non-atomic stores for whole table entry updating. This may cause incorrect nexthop to be returned, if the byte with valid flag is updated prior to the byte with next hot is updated. Changed to use atomic store to update whole table entry. Suggested-by: Medvedkin Vladimir