Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-15 Thread Anoob Joseph
Hi Nelio, Agreed. Those can be addressed in other patches. I just wanted your opinion on how the present patch can be finalized keeping in mind the situations that we should address. And yeah, with the change in commit log, this should be enough. Thanks, Anoob On 15-12-2017 22:23, Nelio L

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-15 Thread Nelio Laranjeiro
Hi Anoob, Seems you want to address a lot of stuff where is should be done in a different series, please see below, On Fri, Dec 15, 2017 at 09:09:00PM +0530, Anoob Joseph wrote: > Hi Nelio, > > > On 15-12-2017 19:23, Nelio Laranjeiro wrote: > > Hi Anoob, > > > > On Fri, Dec 15, 2017 at 02:35:1

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-15 Thread Anoob Joseph
Hi Nelio, On 15-12-2017 19:23, Nelio Laranjeiro wrote: Hi Anoob, On Fri, Dec 15, 2017 at 02:35:12PM +0530, Anoob Joseph wrote: Hi Nelio, On 12/14/2017 08:44 PM, Nelio Laranjeiro wrote: Add Egress flow create for devices supporting RTE_SECURITY_TX_HW_TRAILER_OFFLOAD. Signed-off-by: Nelio La

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-15 Thread Nelio Laranjeiro
Hi Anoob, On Fri, Dec 15, 2017 at 02:35:12PM +0530, Anoob Joseph wrote: > Hi Nelio, > > On 12/14/2017 08:44 PM, Nelio Laranjeiro wrote: > > Add Egress flow create for devices supporting > > RTE_SECURITY_TX_HW_TRAILER_OFFLOAD. > > > > Signed-off-by: Nelio Laranjeiro > > --- > > examples/ipsec-

Re: [dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-15 Thread Anoob Joseph
Hi Nelio, On 12/14/2017 08:44 PM, Nelio Laranjeiro wrote: Add Egress flow create for devices supporting RTE_SECURITY_TX_HW_TRAILER_OFFLOAD. Signed-off-by: Nelio Laranjeiro --- examples/ipsec-secgw/ipsec.c | 8 1 file changed, 8 insertions(+) diff --git a/examples/ipsec-secgw/ipse

[dpdk-dev] [PATCH v4 3/3] examples/ipsec-secgw: add Egress flow actions

2017-12-14 Thread Nelio Laranjeiro
Add Egress flow create for devices supporting RTE_SECURITY_TX_HW_TRAILER_OFFLOAD. Signed-off-by: Nelio Laranjeiro --- examples/ipsec-secgw/ipsec.c | 8 1 file changed, 8 insertions(+) diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c index 8e8dc6df7..d49970ad8 10