Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> > > > > > >>> > > > >>> + > > > >>> +static int > > > >>> +ixgbe_crypto_update_mb(void *device __rte_unused, > > > >>> + struct rte_security_session *session, > > > >>> +struct rte_mbuf *m, void *params __rte_unused) > > { > > > > > > > > > >

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Nicolau, Radu
; >> ; dev@dpdk.org > > >> Cc: Doherty, Declan ; De Lara Guarch, > > >> Pablo ; > > hemant.agra...@nxp.com; > > >> bor...@mellanox.com; avia...@mellanox.com; > tho...@monjalon.net; > > >> sandeep.ma...@nxp.com; jerin.ja...@caviumnetworks.com;

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
De Lara Guarch, Pablo > >> ; > hemant.agra...@nxp.com; > >> bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > >> sandeep.ma...@nxp.com; jerin.ja...@caviumnetworks.com; > >> Mcnamara, John ; shah...@mellanox.com; > >> olivier.m...@6win

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Radu Nicolau
; hemant.agra...@nxp.com; bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; sandeep.ma...@nxp.com; jerin.ja...@caviumnetworks.com; Mcnamara, John ; shah...@mellanox.com; olivier.m...@6wind.com Subject: Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec -Original Message

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Radu Nicolau
On 10/19/2017 1:16 PM, Ananyev, Konstantin wrote: -Original Message- From: Nicolau, Radu Sent: Thursday, October 19, 2017 12:57 PM To: Ananyev, Konstantin ; Akhil Goyal ; dev@dpdk.org Cc: Doherty, Declan ; De Lara Guarch, Pablo ; hemant.agra...@nxp.com; bor...@mellanox.com; avia...@

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > sandeep.ma...@nxp.com; jerin.ja...@caviumnetworks.com; > Mcnamara, John ; shah...@mellanox.com; > olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec > > > >

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> -Original Message- > From: Nicolau, Radu > Sent: Thursday, October 19, 2017 12:57 PM > To: Ananyev, Konstantin ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; >

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Nicolau, Radu
> -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, October 19, 2017 12:04 PM > To: Nicolau, Radu ; Akhil Goyal > ; dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > bor...@mellanox.com; avia...@mellanox.com; tho...@monjalon.net; > san

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> > > >> > >> + > >> +static int > >> +ixgbe_crypto_update_mb(void *device __rte_unused, > >> + struct rte_security_session *session, > >> + struct rte_mbuf *m, void *params __rte_unused) > >> +{ > >> + struct ixgbe_crypto_session *ic_session = > >> + g

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Radu Nicolau
Hi, Comments inline On 10/18/2017 10:29 PM, Ananyev, Konstantin wrote: Hi Radu, Few comments from me below. Konstantin +#define IXGBE_WRITE_REG_THEN_POLL_MASK(hw, reg, val, mask, poll_ms)\ +{ \ + uint32_t cnt =

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-19 Thread Ananyev, Konstantin
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 14b9c53..fcabd5e 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -61,6 +61,7 @@ > #include > #include > #include > +#include > > #include "ixgbe_log

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-18 Thread Ananyev, Konstantin
Hi Radu, Few comments from me below. Konstantin > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Saturday, October 14, 2017 11:18 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; De Lara Guarch, Pablo > ; hemant.agra...@nxp.com; > Nicolau, Radu ; bor...@mellanox.

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-16 Thread Thomas Monjalon
15/10/2017 14:51, Aviad Yehezkel: > > On 10/15/2017 1:17 AM, Akhil Goyal wrote: > > From: Radu Nicolau > > > > Signed-off-by: Radu Nicolau > > Signed-off-by: Declan Doherty > > --- > > drivers/net/Makefile | 2 +- > > drivers/net/ixgbe/Makefile | 2 +- > >

Re: [dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-15 Thread Aviad Yehezkel
On 10/15/2017 1:17 AM, Akhil Goyal wrote: From: Radu Nicolau Signed-off-by: Radu Nicolau Signed-off-by: Declan Doherty --- drivers/net/Makefile | 2 +- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/base/ixgbe_osdep.h | 8 + drivers/net/ixgbe

[dpdk-dev] [PATCH v4 10/12] net/ixgbe: enable inline ipsec

2017-10-14 Thread Akhil Goyal
From: Radu Nicolau Signed-off-by: Radu Nicolau Signed-off-by: Declan Doherty --- drivers/net/Makefile | 2 +- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/base/ixgbe_osdep.h | 8 + drivers/net/ixgbe/ixgbe_ethdev.c | 19 + drivers/net/ixgbe/i