Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage

2021-03-23 Thread David Marchand
On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readab

Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage

2021-02-18 Thread David Marchand
On Thu, Feb 18, 2021 at 11:48 AM Ibtisam Tariq wrote: > On Thu, Feb 18, 2021 at 2:59 PM David Marchand > wrote: >> >> On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq >> wrote: >> > >> > Instead of using getopt_long return value, strcmp was used to >> > compare the input parameters with the struct

Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage

2021-02-18 Thread Ibtisam Tariq
Hi David, Thanks for the recommendation. In future, I will add a cover letter for a long patch set. If you want, I can submit the cover letter for this patch set too. On Thu, Feb 18, 2021 at 2:59 PM David Marchand wrote: > On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq > wrote: > > > > Instead o

Re: [dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage

2021-02-18 Thread David Marchand
On Thu, Feb 4, 2021 at 8:34 AM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readab

[dpdk-dev] [PATCH v4 1/7] examples/fips_validation: enhance getopt_long usage

2021-02-03 Thread Ibtisam Tariq
Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: ma