Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add access to eeprom

2018-04-25 Thread Thomas Monjalon
25/04/2018 10:21, Zijie Pan: > Hi Thomas, > > > > +/** > > > + * Placeholder for accessing plugin module eeprom > > > + */ > > > +struct rte_dev_module_info { > > > + uint32_t type; /**< Type of plugin module eeprom */ > > > + uint32_t eeprom_len; /**< Length of plugin module eeprom */ > > > +}; >

Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add access to eeprom

2018-04-25 Thread Zijie Pan
Hi Thomas, > > +/** > > + * Placeholder for accessing plugin module eeprom > > + */ > > +struct rte_dev_module_info { > > + uint32_t type; /**< Type of plugin module eeprom */ > > + uint32_t eeprom_len; /**< Length of plugin module eeprom */ > > +}; > > I am not sure "plugin module" is descriptive

Re: [dpdk-dev] [PATCH v4 1/5] ethdev: add access to eeprom

2018-04-24 Thread Thomas Monjalon
24/04/2018 12:17, Zijie Pan: > +/** > + * Placeholder for accessing plugin module eeprom > + */ > +struct rte_dev_module_info { > + uint32_t type; /**< Type of plugin module eeprom */ > + uint32_t eeprom_len; /**< Length of plugin module eeprom */ > +}; I am not sure "plugin module" is des

[dpdk-dev] [PATCH v4 1/5] ethdev: add access to eeprom

2018-04-24 Thread Zijie Pan
add new APIs: - rte_eth_dev_get_module_info - rte_eth_dev_get_module_eeprom Signed-off-by: Zijie Pan Acked-by: Remy Horton --- Cc: remy.hor...@intel.com Cc: john.mcnam...@intel.com Cc: marko.kovace...@intel.com Cc: tho...@monjalon.net doc/guides/nics/features.rst| 11 li