Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

2018-11-23 Thread Jozwiak, TomaszX
> -Original Message- > From: Richardson, Bruce > Sent: Friday, November 23, 2018 4:25 PM > To: Varghese, Vipin > Cc: Jozwiak, TomaszX ; dev@dpdk.org; Trahe, > Fiona ; shally.ve...@cavium.com; > akhil.go...@nxp.com > Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/c

Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

2018-11-23 Thread Bruce Richardson
On Fri, Nov 23, 2018 at 03:10:51PM +, Varghese, Vipin wrote: > > > > +#define MAX_DRIVER_NAME64 > > +#define MAX_INPUT_FILE_NAME64 > > > > > +comp_perf_options_check(struct comp_test_data *test_data) { > > + if (strcmp(test_data->driver_name, "") == 0) { > > Should w

Re: [dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

2018-11-23 Thread Varghese, Vipin
> +#define MAX_DRIVER_NAME 64 > +#define MAX_INPUT_FILE_NAME 64 > +comp_perf_options_check(struct comp_test_data *test_data) { > + if (strcmp(test_data->driver_name, "") == 0) { Should we use strncmp for boundary? > + RTE_LOG(ERR, USER1, "Driver name has to be s

[dpdk-dev] [PATCH v4 1/5] app/compress-perf: add parser

2018-11-23 Thread Tomasz Jozwiak
Added parser part into compression perf. test. Signed-off-by: De Lara Guarch, Pablo Signed-off-by: Tomasz Jozwiak --- app/Makefile | 4 + app/meson.build | 1 + app/test-compress-perf/Makefile | 16 + app