Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-03 Thread Jack Min
On Wed, 19-07-03, 17:25, Adrien Mazarguil wrote: > On Tue, Jul 02, 2019 at 05:45:52PM +0800, Xiaoyu Min wrote: > > Add new rte_flow_item_gre_key in order to match the optional key field. > > > > Signed-off-by: Xiaoyu Min > > OK with adding this feature, however I still have a bunch of comments b

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-03 Thread Jack Min
On Wed, 19-07-03, 16:06, Thomas Monjalon wrote: > 02/07/2019 11:45, Xiaoyu Min: > > + /** > > +* Matches a GRE optional key field. > > +* > > +* The value should a big-endian 32bit integer. > > +*/ > > + RTE_FLOW_ITEM_TYPE_GRE_KEY, > > We probably want to use the same format as

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-03 Thread Adrien Mazarguil
On Tue, Jul 02, 2019 at 05:45:52PM +0800, Xiaoyu Min wrote: > Add new rte_flow_item_gre_key in order to match the optional key field. > > Signed-off-by: Xiaoyu Min OK with adding this feature, however I still have a bunch of comments below. > --- > doc/guides/prog_guide/rte_flow.rst | 8 ++

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-03 Thread Thomas Monjalon
02/07/2019 11:45, Xiaoyu Min: > + /** > + * Matches a GRE optional key field. > + * > + * The value should a big-endian 32bit integer. > + */ > + RTE_FLOW_ITEM_TYPE_GRE_KEY, We probably want to use the same format as in Dekel's patch for doxygen documentation of the act

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-02 Thread Ori Kam
> -Original Message- > From: Xiaoyu Min > Sent: Tuesday, July 2, 2019 12:46 PM > To: Ori Kam ; Adrien Mazarguil > ; John McNamara > ; Marko Kovacevic > ; Thomas Monjalon ; > Ferruh Yigit ; Andrew Rybchenko > > Cc: dev@dpdk.org > Subject: [Suspected-Phishing][PATCH v4 1/4] ethdev: add G

[dpdk-dev] [PATCH v4 1/4] ethdev: add GRE key field to flow API

2019-07-02 Thread Xiaoyu Min
Add new rte_flow_item_gre_key in order to match the optional key field. Signed-off-by: Xiaoyu Min --- doc/guides/prog_guide/rte_flow.rst | 8 lib/librte_ethdev/rte_flow.c | 1 + lib/librte_ethdev/rte_flow.h | 7 +++ 3 files changed, 16 insertions(+) diff --git a/doc/gui