[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

2015-07-08 Thread Bruce Richardson
On Wed, Jul 08, 2015 at 10:31:15AM +, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Tuesday, July 7, 2015 3:51 PM > > To: Wu, Jingjing > > Cc: dev at dpdk.org > > S

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

2015-07-08 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, July 7, 2015 3:51 PM > To: Wu, Jingjing > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: rename > rte_eth_vmdq_mirror_conf > &

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

2015-07-08 Thread Wu, Jingjing
Thanks for the clarification. Jingjing > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, July 07, 2015 10:51 PM > To: Wu, Jingjing > Cc: dev at dpdk.org; nhorman at tuxdriver.com > Subject: Re: [dpdk-dev] [PATCH v4 1

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

2015-07-07 Thread Thomas Monjalon
2015-06-26 07:03, Wu, Jingjing: > Hi, Neil > > About this patch I have an ABI concern about it. > This patch just renamed a struct rte_eth_vmdq_mirror_conf to > rte_eth_mirror_conf, the size and its elements don't change. > As my understanding, it will not break the ABI. And I also tested it. > B

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

2015-07-06 Thread Wu, Jingjing
xdriver.com' > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: rename > rte_eth_vmdq_mirror_conf > > Hi, Neil > > About this patch I have an ABI concern about it. > This patch just renamed a struct rte_eth_vmdq_mirror_conf to > rte_eth_mirror_co

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

2015-06-26 Thread Wu, Jingjing
Hi, Neil About this patch I have an ABI concern about it. This patch just renamed a struct rte_eth_vmdq_mirror_conf to rte_eth_mirror_conf, the size and its elements don't change. As my understanding, it will not break the ABI. And I also tested it. But when I use the script ./scripts/validate

[dpdk-dev] [PATCH v4 1/4] ethdev: rename rte_eth_vmdq_mirror_conf

2015-06-10 Thread Jingjing Wu
rename rte_eth_vmdq_mirror_conf to rte_eth_mirror_conf and move the maximum rule id check from ethdev level to driver Signed-off-by: Jingjing Wu --- app/test-pmd/cmdline.c | 22 +++--- drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++ drivers/net/ixgbe/ixgbe_ethdev.h |