On Fri, Apr 27, 2018 at 01:03:31AM +0300, Medvedkin Vladimir wrote:
> Signed-off-by: Medvedkin Vladimir
> ---
> config/common_base | 6 +
> doc/api/doxy-api.conf | 1 +
> lib/Makefile | 2 +
> lib/librte_rib/Makefile| 23 ++
>
On Fri, Apr 27, 2018 at 01:03:31AM +0300, Medvedkin Vladimir wrote:
> Signed-off-by: Medvedkin Vladimir
> ---
> config/common_base | 6 +
> doc/api/doxy-api.conf | 1 +
> lib/Makefile | 2 +
> lib/librte_rib/Makefile| 23 ++
>
Hi Stephen,
Thanks for comments! Will fix in next version.
2018-04-27 1:20 GMT+03:00 Stephen Hemminger :
> On Fri, 27 Apr 2018 01:03:31 +0300
> Medvedkin Vladimir wrote:
>
> > + /**
> > + * Intermediate node found.
> > + * Previous rte_rib_tree_lookup_exact
On Fri, 27 Apr 2018 01:03:31 +0300
Medvedkin Vladimir wrote:
> + /**
> + * Intermediate node found.
> + * Previous rte_rib_tree_lookup_exact() returned NULL
> + * but node with proper search criteria is found.
> + * Validate intermed
On Fri, 27 Apr 2018 01:03:31 +0300
Medvedkin Vladimir wrote:
> rib = (struct rte_rib *)rte_zmalloc_socket(mem_name,
> + sizeof(struct rte_rib), RTE_CACHE_LINE_SIZE, socket_id);
Cast of void * pointer is not required in C.
On Fri, 27 Apr 2018 01:03:31 +0300
Medvedkin Vladimir wrote:
> + snprintf(rib->name, sizeof(rib->name), "%s", name);
Use strlcpy
On Fri, 27 Apr 2018 01:03:31 +0300
Medvedkin Vladimir wrote:
> +/**
> + * Check if prefix1 {key1/depth1}
> + * is covered by prefix2 {key2/depth2}
> + */
> +static inline int __attribute__((pure))
> +rte_rib_is_covered(uint32_t key1, uint8_t depth1, uint32_t key2, uint8_t
> depth2)
> +{
> +
On Fri, 27 Apr 2018 01:03:31 +0300
Medvedkin Vladimir wrote:
> +static inline int __attribute__((pure))
> +rte_rib_is_right_node(struct rte_rib_node *node)
> +{
> + return (node->parent->right == node);
> +}
> +
Minor nit (repeated in several places).
DPDK uses Linux (not BSD) style where ex
Signed-off-by: Medvedkin Vladimir
---
config/common_base | 6 +
doc/api/doxy-api.conf | 1 +
lib/Makefile | 2 +
lib/librte_rib/Makefile| 23 ++
lib/librte_rib/meson.build | 6 +
lib/librte_rib/rte_rib.c | 5
9 matches
Mail list logo
