Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-05-01 Thread Dai, Wei
> > > > > > > > int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int > > > > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c > > > > b/drivers/net/e1000/base/e1000_api.c > > > > index f7cf83b..dcb53f7 100644 > > > > --- a/drivers/net/e1000/base/e1000_api.c > > > > +++ b/drive

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-05-01 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Saturday, April 29, 2017 2:09 PM > To: Lu, Wenzhuo; thomas.monja...@6wind.com; harish.pa...@cavium.com; > rasesh.m...@cavium.com; stephen.h...@broadcom.com; > ajit.khapa...@broadcom.com; Zhang, Helin; Ananyev, Konstantin; Wu, > Jingjin

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-28 Thread Dai, Wei
HI, Wenzhuo > > > > int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int > > wait_to_complete) diff --git a/drivers/net/e1000/base/e1000_api.c > > b/drivers/net/e1000/base/e1000_api.c > > index f7cf83b..dcb53f7 100644 > > --- a/drivers/net/e1000/base/e1000_api.c > > +++ b/drivers/net/e1000/ba

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-20 Thread Lu, Wenzhuo
Hi Wei, > -Original Message- > From: Dai, Wei > Sent: Thursday, April 13, 2017 4:21 PM > To: thomas.monja...@6wind.com; harish.pa...@cavium.com; > rasesh.m...@cavium.com; stephen.h...@broadcom.com; > ajit.khapa...@broadcom.com; Lu, Wenzhuo; Zhang, Helin; Ananyev, > Konstantin; Wu, Jingjing

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-19 Thread Yuanhan Liu
On Thu, Apr 13, 2017 at 04:21:04PM +0800, Wei Dai wrote: > some customers find adding mac addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > > Fixes: af75078f

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-13 Thread Dai, Wei
Thanks, Nelio Laranjeiro. What about other parts, dear maintainers ? > -Original Message- > From: Nélio Laranjeiro [mailto:nelio.laranje...@6wind.com] > Sent: Thursday, April 13, 2017 4:45 PM > To: Dai, Wei > Cc: thomas.monja...@6wind.com; harish.pa...@cavium.com; > rasesh.m...@cavium.c

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-13 Thread Nélio Laranjeiro
On Thu, Apr 13, 2017 at 04:21:04PM +0800, Wei Dai wrote: > some customers find adding mac addr to VF sometimes can fail, > but it is still stored in dev->data->mac_addrs[ ]. So this > can lead to some errors that assumes the non-zero entry in > dev->data->mac_addrs[ ] is valid. > > Fixes: af75078f

[dpdk-dev] [PATCH v4 1/3] ethdev: fix adding invalid MAC addr

2017-04-13 Thread Wei Dai
some customers find adding mac addr to VF sometimes can fail, but it is still stored in dev->data->mac_addrs[ ]. So this can lead to some errors that assumes the non-zero entry in dev->data->mac_addrs[ ] is valid. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Wei