Re: [dpdk-dev] [PATCH v4 01/15] ethdev: move queue state defines to private file

2019-10-22 Thread Andrew Rybchenko
On 10/17/19 6:32 PM, Ori Kam wrote: The queue state defines are internal to the DPDK. This commit moves them to a private header file. Signed-off-by: Ori Kam Reviewed-by: Andrew Rybchenko Yes, there is a lot of space for improvements in queue state management etc, but this one is a step in

Re: [dpdk-dev] [PATCH v4 01/15] ethdev: move queue state defines to private file

2019-10-17 Thread Stephen Hemminger
On Thu, 17 Oct 2019 15:32:03 + Ori Kam wrote: > /** > + * RX/TX queue states > + */ > +#define RTE_ETH_QUEUE_STATE_STOPPED 0 > +#define RTE_ETH_QUEUE_STATE_STARTED 1 Why not make it an enum?

[dpdk-dev] [PATCH v4 01/15] ethdev: move queue state defines to private file

2019-10-17 Thread Ori Kam
The queue state defines are internal to the DPDK. This commit moves them to a private header file. Signed-off-by: Ori Kam --- V4: - new file, created due to ML comments. --- lib/librte_ethdev/rte_ethdev.h| 6 -- lib/librte_ethdev/rte_ethdev_driver.h | 6 ++ 2 files changed, 6