On Tue, Sep 20, 2016 at 06:42:02PM +, Dey, Souvik wrote:
> I have already taken care of this in v5 of the patch , If possible please
> review the same .
I don't think so, otherwise I would not comment here.
BTW, there is a format error: you used white space instead of TAB for
indention.
You
I have already taken care of this in v5 of the patch , If possible please
review the same .
-Original Message-
From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
Sent: Tuesday, September 20, 2016 3:12 AM
To: Kavanagh, Mark B
Cc: Dey, Souvik ; dev at dpdk.org; stephen at
networkplum
On Wed, Sep 14, 2016 at 12:15:37PM +, Kavanagh, Mark B wrote:
> >
> >>+{
> >>+?? struct rte_eth_dev_info dev_info;
> >>+?? uint32_t ether_hdr_len = ETHER_HDR_LEN + ETHER_CRC_LEN +
> >>+VLAN_TAG_LEN;
> >>+?? uint32_t frame_size = mtu + ether_hdr_len;
> >>+
> >>+?? virtio_dev_info
Hi Mark/Liu,
I know this might be a redundant question, but should I put your names
in the Reviewed-by section in v5 ?
--
Regards,
Souvik
-Original Message-
From: Kavanagh, Mark B [mailto:mark.b.kavan...@intel.com]
Sent: Wednesday, September 14, 2016 8:16 AM
To: Dey, Souvik ; Y
On Wed, Sep 14, 2016 at 12:25:21AM +, Dey, Souvik wrote:
> Hi Mark/Liu,
> Is there any further comments to the below patch ? Should I submit it
> as v5 of the patch ?
I think I'm okay with the patch now. But I got one more ask for you :)
In commit log, you stated:
Virtio interfac
>
>>
>>Hi Mark/Liu,
>>? Thanks to both of you for being so patient with a series
>>of silly errors. I have tried to make it better this time. Also there
>>were some un-used variable in the function which I have removed. Please
>>check the new patch with all your comments incorporated. A
; Yuanhan Liu
Cc: dev at dpdk.org; stephen at networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio
-Original Message-
From: Kavanagh, Mark B [mailto:mark.b.kavan...@intel.com]
Sent: Monday, September 12, 2016 10:48 AM
To: Dey, Souvik ; Yuanhan Liu
Cc: dev at
-Original Message-
From: Kavanagh, Mark B [mailto:mark.b.kavan...@intel.com]
Sent: Monday, September 12, 2016 10:48 AM
To: Dey, Souvik ; Yuanhan Liu
Cc: dev at dpdk.org; stephen at networkplumber.org
Subject: RE: [PATCH v4]net/virtio: add mtu set in virtio
>
>Hi Mark/Liu,
>
>
>Hi Mark/Liu,
>? Thanks to both of you for being so patient with a series of
>silly errors. I
>have tried to make it better this time. Also there were some un-used variable
>in the function
>which I have removed. Please check the new patch with all your comments
>incorporated. Also
, Mark B ; Yuanhan Liu
Cc: dev at dpdk.org; stephen at networkplumber.org
Subject: Re: [dpdk-dev] [PATCH v4]net/virtio: add mtu set in virtio
Hi Mark/Liu,
Thanks to both of you for being so patient with a series of silly
errors. I have tried to make it better this time. Also there
On Fri, Sep 09, 2016 at 03:33:32PM +, Dey, Souvik wrote:
> Hi Mark,
>
> Yes I thought I did that change. Sorry once again.. making too many mistakes.
> Changed it . Thanks.
> The MTU here is L3 MTU. Setting this will help in reducing the
> fragmented/multi-segmented packets and also in cas
Hi Mark/Liu,
Thanks to both of you for being so patient with a series of silly
errors. I have tried to make it better this time. Also there were some un-used
variable in the function which I have removed. Please check the new patch with
all your comments incorporated. Also along w
>
>Hi Mark,
>
>Yes I thought I did that change. Sorry once again.. making too many mistakes.
>Changed it .
>Thanks.
>The MTU here is L3 MTU. Setting this will help in reducing the
>fragmented/multi-segmented
>packets and also in case we want to reduce the MTU below 1500, to support
>VXLAN or GR
Hi Mark,
Yes I thought I did that change. Sorry once again.. making too many mistakes.
Changed it . Thanks.
The MTU here is L3 MTU. Setting this will help in reducing the
fragmented/multi-segmented packets and also in case we want to reduce the MTU
below 1500, to support VXLAN or GRE tunnel f
>
>Hi Liu,
>
>Yes agreed your comment. I will definitely remove the declaration as it is not
>really
>required.
> So the latest patch will look like this . Yes I did rush a bit to submit the
> patch last will
>correct my suite. So sending the patch in a reply if we have more comments we
>can tak
On Wed, Sep 07, 2016 at 04:21:30AM +, Dey, Souvik wrote:
> Hi Liu,
> Submitted the version 4 of the patch as you suggested ,
Your patch is looking much better. But not really, you ignored few of
my comments.
> and have removed the Reviewed by line.
> I have still kept the function defin
Hi Liu,
Yes agreed your comment. I will definitely remove the declaration as it is not
really required.
So the latest patch will look like this . Yes I did rush a bit to submit the
patch last will correct my suite. So sending the patch in a reply if we have
more comments we can take a look an
Hi Liu,
Submitted the version 4 of the patch as you suggested , and have
removed the Reviewed by line.
I have still kept the function definition as to follow the same suit as we have
done for other eth_dev_ops.
--
Regards,
Souvik
-Original Message-
From: Dey, Souvik
Sent: Wedne
Virtio interfaces should also support setting of mtu, as in case of cloud
it is expected to have the consistent mtu across the infrastructure that
the dhcp server sends and not hardcoded to 1500(default).
Changes in v4: Incorporated review comments.
Changes in v3: Corrected few style errors as re
19 matches
Mail list logo
