Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-18 Thread Akhil Goyal
> Hi Akhil, > > If you replace mock_session_create_exp.ret with > mock_session_destroy_exp.ret > in mock_session_destroy() everything works fine and all test cases pass. > Thanks for pointing this out. V5 sent. > >>> @@ -1396,6 +1518,7 @@ test_session_destroy_success(void) > >>> mock_

Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-18 Thread Lukasz Wojciechowski
Just to be clear, these are the changes that will fix v4: diff --git a/app/test/test_security.c b/app/test/test_security.c index 62e4991eb..060cf1ffa 100644 --- a/app/test/test_security.c +++ b/app/test/test_security.c @@ -395,7 +395,7 @@ mock_session_destroy(void *device, struct rte_security_ses

Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-18 Thread Lukasz Wojciechowski
Hi Akhil, If you replace mock_session_create_exp.ret with mock_session_destroy_exp.ret in mock_session_destroy() everything works fine and all test cases pass. W dniu 18.10.2020 o 10:47, Akhil Goyal pisze: > Hi Lukasz, >> Hi Akhil, >> >> just one more thing, rest looks good >> >> >>> diff --git

Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-18 Thread Akhil Goyal
Hi Lukasz, > Hi Akhil, > > just one more thing, rest looks good > > > > diff --git a/app/test/test_security.c b/app/test/test_security.c > > index 77fd5adc6..62e4991eb 100644 > > --- a/app/test/test_security.c > > +++ b/app/test/test_security.c > > @@ -363,8 +392,13 @@ static struct mock_session

Re: [dpdk-dev] [PATCH v4] security: update session create API

2020-10-17 Thread Lukasz Wojciechowski
Hi Akhil, just one more thing, rest looks good > diff --git a/app/test/test_security.c b/app/test/test_security.c > index 77fd5adc6..62e4991eb 100644 > --- a/app/test/test_security.c > +++ b/app/test/test_security.c > @@ -363,8 +392,13 @@ static struct mock_session_destroy_data { > static int

[dpdk-dev] [PATCH v4] security: update session create API

2020-10-17 Thread Akhil Goyal
The API ``rte_security_session_create`` takes only single mempool for session and session private data. So the application need to create mempool for twice the number of sessions needed and will also lead to wastage of memory as session private data need more memory compared to session. Hence the A